(Proposal) Adjustments to "decomp" language (#308)

* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions

View File

@@ -8,25 +8,25 @@
DECOMP_SIZE_ASSERT(MxEventPresenter, 0x54);
// OFFSET: LEGO1 0x100c2b70
// FUNCTION: LEGO1 0x100c2b70
MxEventPresenter::MxEventPresenter()
{
Init();
}
// OFFSET: LEGO1 0x100c2d40
// FUNCTION: LEGO1 0x100c2d40
MxEventPresenter::~MxEventPresenter()
{
Destroy();
}
// OFFSET: LEGO1 0x100c2da0
// FUNCTION: LEGO1 0x100c2da0
void MxEventPresenter::Init()
{
m_data = NULL;
}
// OFFSET: LEGO1 0x100c2db0
// FUNCTION: LEGO1 0x100c2db0
MxResult MxEventPresenter::AddToManager()
{
MxResult ret = FAILURE;
@@ -39,7 +39,7 @@ MxResult MxEventPresenter::AddToManager()
return ret;
}
// OFFSET: LEGO1 0x100c2de0
// FUNCTION: LEGO1 0x100c2de0
void MxEventPresenter::Destroy()
{
if (EventManager())
@@ -55,14 +55,14 @@ void MxEventPresenter::Destroy()
m_criticalSection.Leave();
}
// OFFSET: LEGO1 0x100c2e30
// FUNCTION: LEGO1 0x100c2e30
void MxEventPresenter::CopyData(MxStreamChunk* p_chunk)
{
m_data = new MxU8[p_chunk->GetLength()];
memcpy(m_data, p_chunk->GetData(), p_chunk->GetLength());
}
// OFFSET: LEGO1 0x100c2e70
// FUNCTION: LEGO1 0x100c2e70
void MxEventPresenter::ReadyTickle()
{
MxStreamChunk* chunk = NextChunk();
@@ -76,7 +76,7 @@ void MxEventPresenter::ReadyTickle()
}
}
// OFFSET: LEGO1 0x100c2eb0
// FUNCTION: LEGO1 0x100c2eb0
void MxEventPresenter::StartingTickle()
{
MxStreamChunk* chunk = NextChunk();
@@ -87,7 +87,7 @@ void MxEventPresenter::StartingTickle()
}
}
// OFFSET: LEGO1 0x100c2ef0
// FUNCTION: LEGO1 0x100c2ef0
MxResult MxEventPresenter::PutData()
{
MxAutoLocker lock(&m_criticalSection);