mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 08:24:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

(Proposal) Adjustments to "decomp" language (#308)

Browse Source 
* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
LEGO1/mxmediamanager.cpp
View File

@@ -8,19 +8,19 @@
DECOMP_SIZE_ASSERT(MxMediaManager, 0x2c);
// OFFSET: LEGO1 0x100b84c0
// FUNCTION: LEGO1 0x100b84c0
MxMediaManager::MxMediaManager()
{
Init();
}
// OFFSET: LEGO1 0x100b8560
// FUNCTION: LEGO1 0x100b8560
MxMediaManager::~MxMediaManager()
{
Destroy();
}
// OFFSET: LEGO1 0x100b85d0
// FUNCTION: LEGO1 0x100b85d0
MxResult MxMediaManager::Init()
{
this->m_presenters = NULL;
@@ -28,7 +28,7 @@ MxResult MxMediaManager::Init()
return SUCCESS;
}
// OFFSET: LEGO1 0x100b85e0
// FUNCTION: LEGO1 0x100b85e0
MxResult MxMediaManager::InitPresenters()
{
MxAutoLocker lock(&this->m_criticalSection);
@@ -43,7 +43,7 @@ MxResult MxMediaManager::InitPresenters()
return SUCCESS;
}
// OFFSET: LEGO1 0x100b8710
// FUNCTION: LEGO1 0x100b8710
void MxMediaManager::Destroy()
{
MxAutoLocker lock(&this->m_criticalSection);
@@ -54,7 +54,7 @@ void MxMediaManager::Destroy()
Init();
}
// OFFSET: LEGO1 0x100b8790
// FUNCTION: LEGO1 0x100b8790
MxResult MxMediaManager::Tickle()
{
MxAutoLocker lock(&this->m_criticalSection);
@@ -72,7 +72,7 @@ MxResult MxMediaManager::Tickle()
return SUCCESS;
}
// OFFSET: LEGO1 0x100b88c0
// FUNCTION: LEGO1 0x100b88c0
void MxMediaManager::AddPresenter(MxPresenter& p_presenter)
{
MxAutoLocker lock(&this->m_criticalSection);
@@ -80,7 +80,7 @@ void MxMediaManager::AddPresenter(MxPresenter& p_presenter)
this->m_presenters->Append(&p_presenter);
}
// OFFSET: LEGO1 0x100b8980
// FUNCTION: LEGO1 0x100b8980
void MxMediaManager::RemovePresenter(MxPresenter& p_presenter)
{
MxAutoLocker lock(&this->m_criticalSection);
@@ -90,7 +90,7 @@ void MxMediaManager::RemovePresenter(MxPresenter& p_presenter)
cursor.Detach();
}
// OFFSET: LEGO1 0x100b8ac0
// FUNCTION: LEGO1 0x100b8ac0
void MxMediaManager::StopPresenters()
{
MxAutoLocker lock(&this->m_criticalSection);