mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-24 00:44:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

(Proposal) Adjustments to "decomp" language (#308)

Browse Source 
* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
LEGO1/mxmidipresenter.cpp
View File

@@ -8,25 +8,25 @@
DECOMP_SIZE_ASSERT(MxMIDIPresenter, 0x58);
// OFFSET: LEGO1 0x100c25e0
// FUNCTION: LEGO1 0x100c25e0
MxMIDIPresenter::MxMIDIPresenter()
{
Init();
}
// OFFSET: LEGO1 0x100c27c0
// FUNCTION: LEGO1 0x100c27c0
MxMIDIPresenter::~MxMIDIPresenter()
{
Destroy(TRUE);
}
// OFFSET: LEGO1 0x100c2820
// FUNCTION: LEGO1 0x100c2820
void MxMIDIPresenter::Init()
{
m_chunk = NULL;
}
// OFFSET: LEGO1 0x100c2830
// FUNCTION: LEGO1 0x100c2830
void MxMIDIPresenter::Destroy(MxBool p_fromDestructor)
{
if (MusicManager()) {
@@ -45,7 +45,7 @@ void MxMIDIPresenter::Destroy(MxBool p_fromDestructor)
MxMusicPresenter::Destroy();
}
// OFFSET: LEGO1 0x100c2890
// FUNCTION: LEGO1 0x100c2890
void MxMIDIPresenter::ReadyTickle()
{
MxStreamChunk* chunk = NextChunk();
@@ -58,7 +58,7 @@ void MxMIDIPresenter::ReadyTickle()
}
}
// OFFSET: LEGO1 0x100c28d0
// FUNCTION: LEGO1 0x100c28d0
void MxMIDIPresenter::StartingTickle()
{
MxStreamChunk* chunk = FUN_100b5650();
@@ -69,7 +69,7 @@ void MxMIDIPresenter::StartingTickle()
}
}
// OFFSET: LEGO1 0x100c2910
// FUNCTION: LEGO1 0x100c2910
void MxMIDIPresenter::StreamingTickle()
{
if (m_chunk) {
@@ -80,20 +80,20 @@ void MxMIDIPresenter::StreamingTickle()
m_chunk = NextChunk();
}
// OFFSET: LEGO1 0x100c2940
// FUNCTION: LEGO1 0x100c2940
void MxMIDIPresenter::DoneTickle()
{
if (!MusicManager()->GetMIDIInitialized())
EndAction();
}
// OFFSET: LEGO1 0x100c2960
// FUNCTION: LEGO1 0x100c2960
void MxMIDIPresenter::Destroy()
{
Destroy(FALSE);
}
// OFFSET: LEGO1 0x100c2970
// FUNCTION: LEGO1 0x100c2970
MxResult MxMIDIPresenter::PutData()
{
m_criticalSection.Enter();
@@ -109,7 +109,7 @@ MxResult MxMIDIPresenter::PutData()
return SUCCESS;
}
// OFFSET: LEGO1 0x100c29e0
// FUNCTION: LEGO1 0x100c29e0
void MxMIDIPresenter::EndAction()
{
if (m_action) {
@@ -120,7 +120,7 @@ void MxMIDIPresenter::EndAction()
}
}
// OFFSET: LEGO1 0x100c2a60
// FUNCTION: LEGO1 0x100c2a60
void MxMIDIPresenter::SetVolume(MxS32 p_volume)
{
m_volume = p_volume;