mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 16:34:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

(Proposal) Adjustments to "decomp" language (#308)

Browse Source 
* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
LEGO1/mxsoundmanager.cpp
View File

@@ -9,29 +9,29 @@
DECOMP_SIZE_ASSERT(MxSoundManager, 0x3c);
// OFFSET: LEGO1 0x100ae740
// FUNCTION: LEGO1 0x100ae740
MxSoundManager::MxSoundManager()
{
Init();
}
// OFFSET: LEGO1 0x100ae7b0 TEMPLATE
// SYNTHETIC: LEGO1 0x100ae7b0
// MxSoundManager::`scalar deleting destructor'
// OFFSET: LEGO1 0x100ae7d0
// FUNCTION: LEGO1 0x100ae7d0
MxSoundManager::~MxSoundManager()
{
Destroy(TRUE);
}
// OFFSET: LEGO1 0x100ae830
// FUNCTION: LEGO1 0x100ae830
void MxSoundManager::Init()
{
m_directSound = NULL;
m_dsBuffer = NULL;
}
// OFFSET: LEGO1 0x100ae840
// FUNCTION: LEGO1 0x100ae840
void MxSoundManager::Destroy(MxBool p_fromDestructor)
{
if (this->m_thread) {
@@ -56,7 +56,7 @@ void MxSoundManager::Destroy(MxBool p_fromDestructor)
}
}
// OFFSET: LEGO1 0x100ae8b0
// FUNCTION: LEGO1 0x100ae8b0
MxResult MxSoundManager::Create(MxU32 p_frequencyMS, MxBool p_createThread)
{
MxResult status = FAILURE;
@@ -131,13 +131,13 @@ done:
return status;
}
// OFFSET: LEGO1 0x100aeab0
// FUNCTION: LEGO1 0x100aeab0
void MxSoundManager::Destroy()
{
Destroy(FALSE);
}
// OFFSET: LEGO1 0x100aeac0
// FUNCTION: LEGO1 0x100aeac0
void MxSoundManager::SetVolume(MxS32 p_volume)
{
MxAudioManager::SetVolume(p_volume);
@@ -153,7 +153,7 @@ void MxSoundManager::SetVolume(MxS32 p_volume)
m_criticalSection.Leave();
}
// OFFSET: LEGO1 0x100aebd0
// FUNCTION: LEGO1 0x100aebd0
MxPresenter* MxSoundManager::FUN_100aebd0(const MxAtomId& p_atomId, MxU32 p_objectId)
{
MxAutoLocker lock(&m_criticalSection);
@@ -170,7 +170,7 @@ MxPresenter* MxSoundManager::FUN_100aebd0(const MxAtomId& p_atomId, MxU32 p_obje
return NULL;
}
// OFFSET: LEGO1 0x100aecf0
// FUNCTION: LEGO1 0x100aecf0
MxS32 MxSoundManager::FUN_100aecf0(MxU32 p_unk)
{
if (!p_unk)
@@ -178,7 +178,7 @@ MxS32 MxSoundManager::FUN_100aecf0(MxU32 p_unk)
return g_mxcoreCount[p_unk];
}
// OFFSET: LEGO1 0x100aed10
// FUNCTION: LEGO1 0x100aed10
void MxSoundManager::Pause()
{
MxAutoLocker lock(&m_criticalSection);
@@ -191,7 +191,7 @@ void MxSoundManager::Pause()
((MxWavePresenter*) presenter)->Pause();
}
// OFFSET: LEGO1 0x100aee10
// FUNCTION: LEGO1 0x100aee10
void MxSoundManager::Resume()
{
MxAutoLocker lock(&m_criticalSection);