mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 16:34:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

(Proposal) Adjustments to "decomp" language (#308)

Browse Source 
* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
LEGO1/mxstillpresenter.cpp
View File

@@ -8,28 +8,28 @@
DECOMP_SIZE_ASSERT(MxStillPresenter, 0x6c);
// 0x10101eb0
// GLOBAL: LEGO1 0x10101eb0
const char* g_strBMP_ISMAP = "BMP_ISMAP";
// OFFSET: LEGO1 0x10043550 TEMPLATE
// FUNCTION: LEGO1 0x10043550
// MxStillPresenter::~MxStillPresenter
// OFFSET: LEGO1 0x100435b0
// FUNCTION: LEGO1 0x100435b0
void MxStillPresenter::Destroy()
{
Destroy(FALSE);
}
// OFFSET: LEGO1 0x100435c0 TEMPLATE
// FUNCTION: LEGO1 0x100435c0
// MxStillPresenter::ClassName
// OFFSET: LEGO1 0x100435d0 TEMPLATE
// FUNCTION: LEGO1 0x100435d0
// MxStillPresenter::IsA
// OFFSET: LEGO1 0x100436e0 TEMPLATE
// SYNTHETIC: LEGO1 0x100436e0
// MxStillPresenter::`scalar deleting destructor'
// OFFSET: LEGO1 0x100b9c70
// FUNCTION: LEGO1 0x100b9c70
void MxStillPresenter::Destroy(MxBool p_fromDestructor)
{
m_criticalSection.Enter();
@@ -44,7 +44,7 @@ void MxStillPresenter::Destroy(MxBool p_fromDestructor)
MxVideoPresenter::Destroy(FALSE);
}
// OFFSET: LEGO1 0x100b9cc0
// FUNCTION: LEGO1 0x100b9cc0
void MxStillPresenter::LoadHeader(MxStreamChunk* p_chunk)
{
if (m_bitmapInfo)
@@ -55,7 +55,7 @@ void MxStillPresenter::LoadHeader(MxStreamChunk* p_chunk)
memcpy(m_bitmapInfo, p_chunk->GetData(), p_chunk->GetLength());
}
// OFFSET: LEGO1 0x100b9d10
// FUNCTION: LEGO1 0x100b9d10
void MxStillPresenter::CreateBitmap()
{
if (m_bitmap)
@@ -68,7 +68,7 @@ void MxStillPresenter::CreateBitmap()
m_bitmapInfo = NULL;
}
// OFFSET: LEGO1 0x100b9db0
// FUNCTION: LEGO1 0x100b9db0
void MxStillPresenter::NextFrame()
{
MxStreamChunk* chunk = NextChunk();
@@ -76,7 +76,7 @@ void MxStillPresenter::NextFrame()
m_subscriber->FUN_100b8390(chunk);
}
// OFFSET: LEGO1 0x100b9dd0
// FUNCTION: LEGO1 0x100b9dd0
void MxStillPresenter::LoadFrame(MxStreamChunk* p_chunk)
{
memcpy(m_bitmap->GetBitmapData(), p_chunk->GetData(), p_chunk->GetLength());
@@ -113,43 +113,43 @@ void MxStillPresenter::LoadFrame(MxStreamChunk* p_chunk)
}
}
// OFFSET: LEGO1 0x100b9f30 STUB
// STUB: LEGO1 0x100b9f30
void MxStillPresenter::VTable0x70()
{
// TODO
}
// OFFSET: LEGO1 0x100b9f60 STUB
// STUB: LEGO1 0x100b9f60
void MxStillPresenter::StartingTickle()
{
// TODO
}
// OFFSET: LEGO1 0x100b9f90 STUB
// STUB: LEGO1 0x100b9f90
void MxStillPresenter::StreamingTickle()
{
// TODO
}
// OFFSET: LEGO1 0x100b9ff0 STUB
// STUB: LEGO1 0x100b9ff0
void MxStillPresenter::RepeatingTickle()
{
// TODO
}
// OFFSET: LEGO1 0x100ba040 STUB
// STUB: LEGO1 0x100ba040
void MxStillPresenter::VTable0x88(undefined4, undefined4)
{
// TODO
}
// OFFSET: LEGO1 0x100ba140 STUB
// STUB: LEGO1 0x100ba140
void MxStillPresenter::Enable(MxBool p_enable)
{
// TODO
}
// OFFSET: LEGO1 0x100ba1e0
// FUNCTION: LEGO1 0x100ba1e0
void MxStillPresenter::ParseExtra()
{
MxPresenter::ParseExtra();
@@ -182,7 +182,7 @@ void MxStillPresenter::ParseExtra()
}
}
// OFFSET: LEGO1 0x100ba2c0 STUB
// STUB: LEGO1 0x100ba2c0
MxStillPresenter* MxStillPresenter::Clone()
{
// TODO