mirror of
https://github.com/isledecomp/isle.git
synced 2025-10-24 08:54:15 +00:00
(Proposal) Adjustments to "decomp" language (#308)
* Adjustments to "decomp" language * Fix a comment * Fix accidental clang-formatting * Fix order * Fix order * Remove junk * Fix OFFSET * Adjustments based on new suggestions * Annotate globals * Globals in ISLE * More globals * Merge from parser2 branch * Allow prepending space for exact marker match * To eliminate noise, require the 0x prefix on offset for marker match * fix test from previous * Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise * FUNCTION to SYNTHETIC where needed * Missed marker conversion on SetAtomId * pylint cleanup, remove unused code * Fix unexpected function end, add more unit tests * Be more strict about synthetic name syntax * Revert "Missed marker conversion on SetAtomId" This reverts commitd87d665127. * Revert "FUNCTION to SYNTHETIC where needed" This reverts commit8c815418d2. * Implicit lookup by name for functions * Fix VTABLE SYNTHETIC and other decomp markers * Get vtable class name * Vtable marker should identify struct * No colon for SIZE comment * Update README.md * Update README.md * Update CONTRIBUTING.md * Update README.md * Update README.md * Update CONTRIBUTING.md * Update README.md * Update CONTRIBUTING.md * Fix destructor/annotation * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md --------- Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
committed by
GitHub
GitHub
parent
4f5b70013f
commit
494a556f8e
@@ -8,25 +8,25 @@
|
||||
DECOMP_SIZE_ASSERT(MxStreamController, 0x64)
|
||||
DECOMP_SIZE_ASSERT(MxNextActionDataStart, 0x14)
|
||||
|
||||
// OFFSET: LEGO1 0x100b9400
|
||||
// FUNCTION: LEGO1 0x100b9400
|
||||
MxResult MxStreamController::vtable0x18(undefined4 p_unknown, undefined4 p_unknown2)
|
||||
{
|
||||
return FAILURE;
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100b9410
|
||||
// FUNCTION: LEGO1 0x100b9410
|
||||
MxResult MxStreamController::vtable0x1C(undefined4 p_unknown, undefined4 p_unknown2)
|
||||
{
|
||||
return FAILURE;
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100b9420
|
||||
// FUNCTION: LEGO1 0x100b9420
|
||||
MxResult MxStreamController::vtable0x28()
|
||||
{
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100c0b90
|
||||
// FUNCTION: LEGO1 0x100c0b90
|
||||
MxStreamController::MxStreamController()
|
||||
{
|
||||
m_provider = NULL;
|
||||
@@ -34,57 +34,57 @@ MxStreamController::MxStreamController()
|
||||
m_action0x60 = NULL;
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100c0d60 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c0d60
|
||||
// list<MxDSAction *,allocator<MxDSAction *> >::~list<MxDSAction *,allocator<MxDSAction *> >
|
||||
|
||||
// OFFSET: LEGO1 0x100c0dd0 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c0dd0
|
||||
// list<MxDSSubscriber *,allocator<MxDSSubscriber *> >::~list<MxDSSubscriber *,allocator<MxDSSubscriber *> >
|
||||
|
||||
// OFFSET: LEGO1 0x100c0e40 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c0e40
|
||||
// list<MxDSSubscriber *,allocator<MxDSSubscriber *> >::_Buynode
|
||||
|
||||
// clang-format off
|
||||
// OFFSET: LEGO1 0x100c0e70 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c0e70
|
||||
// list<MxNextActionDataStart *,allocator<MxNextActionDataStart *> >::~list<MxNextActionDataStart *,allocator<MxNextActionDataStart *> >
|
||||
// clang-format on
|
||||
|
||||
// OFFSET: LEGO1 0x100c0ee0 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c0ee0
|
||||
// list<MxNextActionDataStart *,allocator<MxNextActionDataStart *> >::_Buynode
|
||||
|
||||
// OFFSET: LEGO1 0x100c0fc0 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c0fc0
|
||||
// MxStreamListMxDSSubscriber::~MxStreamListMxDSSubscriber
|
||||
|
||||
// OFFSET: LEGO1 0x100c1010 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c1010
|
||||
// MxStreamListMxDSAction::~MxStreamListMxDSAction
|
||||
|
||||
// OFFSET: LEGO1 0x100c1060 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c1060
|
||||
// MxStreamListMxNextActionDataStart::~MxStreamListMxNextActionDataStart
|
||||
|
||||
// OFFSET: LEGO1 0x100c10b0 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c10b0
|
||||
// MxStreamList<MxDSSubscriber *>::~MxStreamList<MxDSSubscriber *>
|
||||
|
||||
// OFFSET: LEGO1 0x100c1100 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c1100
|
||||
// MxStreamList<MxDSAction *>::~MxStreamList<MxDSAction *>
|
||||
|
||||
// OFFSET: LEGO1 0x100c1150 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c1150
|
||||
// MxStreamList<MxNextActionDataStart *>::~MxStreamList<MxNextActionDataStart *>
|
||||
|
||||
// OFFSET: LEGO1 0x100c11a0 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c11a0
|
||||
// List<MxDSSubscriber *>::~List<MxDSSubscriber *>
|
||||
|
||||
// OFFSET: LEGO1 0x100c11f0 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c11f0
|
||||
// List<MxDSAction *>::~List<MxDSAction *>
|
||||
|
||||
// OFFSET: LEGO1 0x100c1240 TEMPLATE
|
||||
// TEMPLATE: LEGO1 0x100c1240
|
||||
// List<MxNextActionDataStart *>::~List<MxNextActionDataStart *>
|
||||
|
||||
// OFFSET: LEGO1 0x100c1290 STUB
|
||||
// STUB: LEGO1 0x100c1290
|
||||
MxStreamController::~MxStreamController()
|
||||
{
|
||||
// TODO
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100c1520
|
||||
// FUNCTION: LEGO1 0x100c1520
|
||||
MxResult MxStreamController::Open(const char* p_filename)
|
||||
{
|
||||
char sourceName[256];
|
||||
@@ -95,7 +95,7 @@ MxResult MxStreamController::Open(const char* p_filename)
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100c1690
|
||||
// FUNCTION: LEGO1 0x100c1690
|
||||
MxResult MxStreamController::vtable0x20(MxDSAction* p_action)
|
||||
{
|
||||
MxAutoLocker locker(&m_criticalSection);
|
||||
@@ -117,14 +117,14 @@ MxResult MxStreamController::vtable0x20(MxDSAction* p_action)
|
||||
return result;
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100c1740 STUB
|
||||
// STUB: LEGO1 0x100c1740
|
||||
MxResult MxStreamController::vtable0x24(undefined4 p_unknown)
|
||||
{
|
||||
// TODO STUB
|
||||
return FAILURE;
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100c1800
|
||||
// FUNCTION: LEGO1 0x100c1800
|
||||
MxResult MxStreamController::FUN_100c1800(MxDSAction* p_action, MxU32 p_val)
|
||||
{
|
||||
MxNextActionDataStart* dataActionStart =
|
||||
@@ -137,13 +137,13 @@ MxResult MxStreamController::FUN_100c1800(MxDSAction* p_action, MxU32 p_val)
|
||||
return SUCCESS;
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100c1a00 STUB
|
||||
// STUB: LEGO1 0x100c1a00
|
||||
MxResult MxStreamController::FUN_100c1a00(MxDSAction* p_action, MxU32 p_bufferval)
|
||||
{
|
||||
return FAILURE;
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100c1c10
|
||||
// FUNCTION: LEGO1 0x100c1c10
|
||||
MxResult MxStreamController::vtable0x2c(MxDSAction* p_action, MxU32 p_bufferval)
|
||||
{
|
||||
MxAutoLocker locker(&m_criticalSection);
|
||||
@@ -153,13 +153,13 @@ MxResult MxStreamController::vtable0x2c(MxDSAction* p_action, MxU32 p_bufferval)
|
||||
return FUN_100c1800(p_action, (p_bufferval / m_provider->GetFileSize()) * m_provider->GetFileSize());
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100c1ce0 STUB
|
||||
// STUB: LEGO1 0x100c1ce0
|
||||
MxResult MxStreamController::vtable0x30(undefined4 p_unknown)
|
||||
{
|
||||
return FAILURE;
|
||||
}
|
||||
|
||||
// OFFSET: LEGO1 0x100c20d0 STUB
|
||||
// STUB: LEGO1 0x100c20d0
|
||||
MxBool MxStreamController::FUN_100c20d0(MxDSObject& p_obj)
|
||||
{
|
||||
// TODO
|
||||
|
||||
Reference in New Issue
Block a user