mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 16:34:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

(Proposal) Adjustments to "decomp" language (#308)

Browse Source 
* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
LEGO1/mxstring.cpp
View File

@@ -7,7 +7,7 @@
DECOMP_SIZE_ASSERT(MxString, 0x10)
// OFFSET: LEGO1 0x100ae200
// FUNCTION: LEGO1 0x100ae200
MxString::MxString()
{
// Set string to one char in length and set that char to null terminator
@@ -16,7 +16,7 @@ MxString::MxString()
this->m_length = 0;
}
// OFFSET: LEGO1 0x100ae2a0
// FUNCTION: LEGO1 0x100ae2a0
MxString::MxString(const MxString& str)
{
this->m_length = str.m_length;
@@ -24,7 +24,7 @@ MxString::MxString(const MxString& str)
strcpy(this->m_data, str.m_data);
}
// OFFSET: LEGO1 0x100ae350
// FUNCTION: LEGO1 0x100ae350
MxString::MxString(const char* str)
{
if (str) {
@@ -39,25 +39,25 @@ MxString::MxString(const char* str)
}
}
// OFFSET: LEGO1 0x100ae420
// FUNCTION: LEGO1 0x100ae420
MxString::~MxString()
{
delete[] this->m_data;
}
// OFFSET: LEGO1 0x100ae490
// FUNCTION: LEGO1 0x100ae490
void MxString::ToUpperCase()
{
strupr(this->m_data);
}
// OFFSET: LEGO1 0x100ae4a0
// FUNCTION: LEGO1 0x100ae4a0
void MxString::ToLowerCase()
{
strlwr(this->m_data);
}
// OFFSET: LEGO1 0x100ae4b0
// FUNCTION: LEGO1 0x100ae4b0
MxString& MxString::operator=(const MxString& param)
{
if (this->m_data != param.m_data) {
@@ -70,7 +70,7 @@ MxString& MxString::operator=(const MxString& param)
return *this;
}
// OFFSET: LEGO1 0x100ae510
// FUNCTION: LEGO1 0x100ae510
const MxString& MxString::operator=(const char* param)
{
if (this->m_data != param) {
@@ -85,7 +85,7 @@ const MxString& MxString::operator=(const char* param)
// Return type is intentionally just MxString, not MxString&.
// This forces MSVC to add $ReturnUdt$ to the stack for 100% match.
// OFFSET: LEGO1 0x100ae580
// FUNCTION: LEGO1 0x100ae580
MxString MxString::operator+(const char* str)
{
// MxString constructor allocates 1 byte for m_data, so free that first
@@ -101,7 +101,7 @@ MxString MxString::operator+(const char* str)
return MxString(tmp);
}
// OFFSET: LEGO1 0x100ae690
// FUNCTION: LEGO1 0x100ae690
MxString& MxString::operator+=(const char* str)
{
int newlen = this->m_length + strlen(str);