(Proposal) Adjustments to "decomp" language (#308)

* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions

View File

@@ -6,7 +6,7 @@
#include <process.h>
// OFFSET: LEGO1 0x100b8bb0
// FUNCTION: LEGO1 0x100b8bb0
MxTickleThread::MxTickleThread(MxCore* p_target, int p_frequencyMS)
{
m_target = p_target;
@@ -14,7 +14,7 @@ MxTickleThread::MxTickleThread(MxCore* p_target, int p_frequencyMS)
}
// Match except for register allocation
// OFFSET: LEGO1 0x100b8c90
// FUNCTION: LEGO1 0x100b8c90
MxResult MxTickleThread::Run()
{
MxTimer* timer = Timer();
@@ -36,7 +36,7 @@ MxResult MxTickleThread::Run()
return MxThread::Run();
}
// OFFSET: LEGO1 0x100bf510
// FUNCTION: LEGO1 0x100bf510
MxThread::MxThread()
{
m_hThread = NULL;
@@ -44,7 +44,7 @@ MxThread::MxThread()
m_threadId = 0;
}
// OFFSET: LEGO1 0x100bf5a0
// FUNCTION: LEGO1 0x100bf5a0
MxThread::~MxThread()
{
if (m_hThread)
@@ -53,7 +53,7 @@ MxThread::~MxThread()
typedef unsigned(__stdcall* ThreadFunc)(void*);
// OFFSET: LEGO1 0x100bf610
// FUNCTION: LEGO1 0x100bf610
MxResult MxThread::Start(int p_stack, int p_flag)
{
MxResult result = FAILURE;
@@ -65,26 +65,26 @@ MxResult MxThread::Start(int p_stack, int p_flag)
return result;
}
// OFFSET: LEGO1 0x100bf660
// FUNCTION: LEGO1 0x100bf660
void MxThread::Sleep(MxS32 p_milliseconds)
{
::Sleep(p_milliseconds);
}
// OFFSET: LEGO1 0x100bf670
// FUNCTION: LEGO1 0x100bf670
void MxThread::Terminate()
{
m_running = FALSE;
m_semaphore.Wait(INFINITE);
}
// OFFSET: LEGO1 0x100bf680
// FUNCTION: LEGO1 0x100bf680
unsigned MxThread::ThreadProc(void* p_thread)
{
return static_cast<MxThread*>(p_thread)->Run();
}
// OFFSET: LEGO1 0x100bf690
// FUNCTION: LEGO1 0x100bf690
MxResult MxThread::Run()
{
m_semaphore.Release(1);