(Proposal) Adjustments to "decomp" language (#308)

* Adjustments to "decomp" language

* Fix a comment

* Fix accidental clang-formatting

* Fix order

* Fix order

* Remove junk

* Fix OFFSET

* Adjustments based on new suggestions

* Annotate globals

* Globals in ISLE

* More globals

* Merge from parser2 branch

* Allow prepending space for exact marker match

* To eliminate noise, require the 0x prefix on offset for marker match

* fix test from previous

* Count tab stops for indented functions to reduce MISSED_END_OF_FUNCTION noise

* FUNCTION to SYNTHETIC where needed

* Missed marker conversion on SetAtomId

* pylint cleanup, remove unused code

* Fix unexpected function end, add more unit tests

* Be more strict about synthetic name syntax

* Revert "Missed marker conversion on SetAtomId"

This reverts commit d87d665127.

* Revert "FUNCTION to SYNTHETIC where needed"

This reverts commit 8c815418d2.

* Implicit lookup by name for functions

* Fix VTABLE SYNTHETIC and other decomp markers

* Get vtable class name

* Vtable marker should identify struct

* No colon for SIZE comment

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update README.md

* Update CONTRIBUTING.md

* Update README.md

* Update CONTRIBUTING.md

* Fix destructor/annotation

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

---------

Co-authored-by: disinvite <disinvite@users.noreply.github.com>
This commit is contained in:
Christian Semmler
2023-12-06 07:10:45 -05:00
committed by GitHub
parent 4f5b70013f
commit 494a556f8e
407 changed files with 3505 additions and 2493 deletions

View File

@@ -10,7 +10,7 @@
DECOMP_SIZE_ASSERT(MxTickleClient, 0x10);
DECOMP_SIZE_ASSERT(MxTickleManager, 0x14);
// OFFSET: LEGO1 0x100bdd10
// FUNCTION: LEGO1 0x100bdd10
MxTickleClient::MxTickleClient(MxCore* p_client, MxTime p_interval)
{
m_flags = 0;
@@ -19,7 +19,7 @@ MxTickleClient::MxTickleClient(MxCore* p_client, MxTime p_interval)
m_lastUpdateTime = -m_interval;
}
// OFFSET: LEGO1 0x100bdd30
// FUNCTION: LEGO1 0x100bdd30
MxTickleManager::~MxTickleManager()
{
while (m_clients.size() != 0) {
@@ -30,7 +30,7 @@ MxTickleManager::~MxTickleManager()
}
// TODO: Match.
// OFFSET: LEGO1 0x100bdde0
// FUNCTION: LEGO1 0x100bdde0
MxResult MxTickleManager::Tickle()
{
MxTime time = Timer()->GetTime();
@@ -59,7 +59,7 @@ MxResult MxTickleManager::Tickle()
return SUCCESS;
}
// OFFSET: LEGO1 0x100bde80
// FUNCTION: LEGO1 0x100bde80
void MxTickleManager::RegisterClient(MxCore* p_client, MxTime p_interval)
{
MxTime interval = GetClientTickleInterval(p_client);
@@ -70,7 +70,7 @@ void MxTickleManager::RegisterClient(MxCore* p_client, MxTime p_interval)
}
}
// OFFSET: LEGO1 0x100bdf60
// FUNCTION: LEGO1 0x100bdf60
void MxTickleManager::UnregisterClient(MxCore* p_client)
{
MxTickleClientPtrList::iterator it = m_clients.begin();
@@ -85,7 +85,7 @@ void MxTickleManager::UnregisterClient(MxCore* p_client)
}
}
// OFFSET: LEGO1 0x100bdfa0
// FUNCTION: LEGO1 0x100bdfa0
void MxTickleManager::SetClientTickleInterval(MxCore* p_client, MxTime p_interval)
{
for (MxTickleClientPtrList::iterator it = m_clients.begin(); it != m_clients.end(); it++) {
@@ -97,7 +97,7 @@ void MxTickleManager::SetClientTickleInterval(MxCore* p_client, MxTime p_interva
}
}
// OFFSET: LEGO1 0x100be000
// FUNCTION: LEGO1 0x100be000
MxTime MxTickleManager::GetClientTickleInterval(MxCore* p_client)
{
MxTickleClientPtrList::iterator it = m_clients.begin();