Tweak MxOmni::Destroy and add more beta annotations (#887)

* Fix long function name

* Omni getter beta annotations

* MxMisc asserts and beta annotations

* Helper function for MxNotificationManager list
This commit is contained in:
MS
2024-05-07 13:00:16 -04:00
committed by GitHub
parent bac891cb0c
commit 4b386fe738
6 changed files with 62 additions and 8 deletions

View File

@@ -188,12 +188,8 @@ void MxOmni::Destroy()
DeleteObject(action);
}
// TODO: private members
if (m_notificationManager) {
while (m_notificationManager->GetQueue()) {
if (m_notificationManager->GetQueue()->size() == 0) {
break;
}
while (!m_notificationManager->IsEmpty()) {
m_notificationManager->Tickle();
}
@@ -211,7 +207,6 @@ void MxOmni::Destroy()
delete m_notificationManager;
delete m_tickleManager;
// There could be a tree/iterator function that does this inline
if (m_atomSet) {
while (m_atomSet->size() != 0) {
// Pop each node and delete its value
@@ -220,8 +215,10 @@ void MxOmni::Destroy()
m_atomSet->erase(begin);
delete value;
}
delete m_atomSet;
}
Init();
}