(Refactor) Use more forward declarations (#881)

* Use more forward declarations

* Use more forward declarations

* Add more forward declarations

* Fix

LEGO1/omni/src/audio/mxmidipresenter.cpp

@@ -3,6 +3,7 @@
 #include "decomp.h"
 #include "mxautolock.h"
 #include "mxdssound.h"
+#include "mxdssubscriber.h"
 #include "mxmisc.h"
 #include "mxmusicmanager.h"
 

LEGO1/omni/src/audio/mxmusicmanager.cpp

@@ -1,6 +1,7 @@
 #include "mxmusicmanager.h"
 
 #include "mxmisc.h"
+#include "mxthread.h"
 #include "mxticklemanager.h"
 
 #include <windows.h>

LEGO1/omni/src/audio/mxsoundmanager.cpp

@@ -1,9 +1,11 @@
 #include "mxsoundmanager.h"
 
 #include "mxautolock.h"
+#include "mxdsaction.h"
 #include "mxmisc.h"
 #include "mxomni.h"
 #include "mxpresenter.h"
+#include "mxthread.h"
 #include "mxticklemanager.h"
 #include "mxwavepresenter.h"
 

LEGO1/omni/src/audio/mxwavepresenter.cpp

@@ -4,6 +4,7 @@
 #include "define.h"
 #include "mxautolock.h"
 #include "mxdssound.h"
+#include "mxdssubscriber.h"
 #include "mxmisc.h"
 #include "mxomni.h"
 #include "mxsoundmanager.h"

LEGO1/omni/src/common/mxcompositepresenter.cpp

@@ -1,6 +1,7 @@
 #include "mxcompositepresenter.h"
 
 #include "decomp.h"
+#include "mxactionnotificationparam.h"
 #include "mxautolock.h"
 #include "mxdsmultiaction.h"
 #include "mxmisc.h"

LEGO1/omni/src/common/mxmediapresenter.cpp

@@ -3,6 +3,7 @@
 #include "mxactionnotificationparam.h"
 #include "mxautolock.h"
 #include "mxcompositepresenter.h"
+#include "mxdssubscriber.h"
 #include "mxmisc.h"
 #include "mxnotificationmanager.h"
 #include "mxstreamchunk.h"

LEGO1/omni/src/event/mxeventpresenter.cpp

@@ -2,6 +2,8 @@
 
 #include "decomp.h"
 #include "mxautolock.h"
+#include "mxdsaction.h"
+#include "mxdssubscriber.h"
 #include "mxeventmanager.h"
 #include "mxmisc.h"
 #include "mxvariabletable.h"

LEGO1/omni/src/main/mxomni.cpp

@@ -15,6 +15,7 @@
 #include "mxstreamer.h"
 #include "mxticklemanager.h"
 #include "mxtimer.h"
+#include "mxvariabletable.h"
 #include "mxvideomanager.h"
 
 // GLOBAL: LEGO1 0x101015b8

LEGO1/omni/src/main/mxomnicreateflags.cpp

@@ -1,5 +1,9 @@
 #include "mxomnicreateflags.h"
 
+#include "decomp.h"
+
+DECOMP_SIZE_ASSERT(MxOmniCreateFlags, 0x02)
+
 // FUNCTION: LEGO1 0x100b0a30
 // FUNCTION: BETA10 0x10130a1c
 MxOmniCreateFlags::MxOmniCreateFlags()

LEGO1/omni/src/main/mxomnicreateparam.cpp

@@ -1,5 +1,9 @@
 #include "mxomnicreateparam.h"
 
+#include "decomp.h"
+
+DECOMP_SIZE_ASSERT(MxOmniCreateParam, 0x40)
+
 // FUNCTION: LEGO1 0x100b0b00
 // FUNCTION: BETA10 0x10130b6b
 MxOmniCreateParam::MxOmniCreateParam(

LEGO1/omni/src/notify/mxnotificationmanager.cpp

@@ -4,6 +4,7 @@
 #include "decomp.h"
 #include "mxautolock.h"
 #include "mxmisc.h"
+#include "mxnotificationparam.h"
 #include "mxparam.h"
 #include "mxticklemanager.h"
 #include "mxtypes.h"

LEGO1/omni/src/stream/mxdiskstreamprovider.cpp

@@ -3,6 +3,7 @@
 #include "mxautolock.h"
 #include "mxdiskstreamcontroller.h"
 #include "mxdsbuffer.h"
+#include "mxdsfile.h"
 #include "mxdsstreamingaction.h"
 #include "mxomni.h"
 #include "mxramstreamprovider.h"

LEGO1/omni/src/stream/mxdsbuffer.cpp

@@ -8,6 +8,7 @@
 #include "mxstreamchunk.h"
 #include "mxstreamcontroller.h"
 #include "mxstreamer.h"
+#include "mxstreamprovider.h"
 
 DECOMP_SIZE_ASSERT(MxDSBuffer, 0x34);
 

LEGO1/omni/src/stream/mxramstreamprovider.cpp

@@ -2,6 +2,7 @@
 
 #include "decomp.h"
 #include "mxdsbuffer.h"
+#include "mxdsfile.h"
 #include "mxomni.h"
 #include "mxstreamcontroller.h"
 

LEGO1/omni/src/stream/mxstreamcontroller.cpp

@@ -7,6 +7,7 @@
 #include "mxnextactiondatastart.h"
 #include "mxstl/stlcompat.h"
 #include "mxstreamchunk.h"
+#include "mxstreamprovider.h"
 #include "mxtimer.h"
 #include "mxutilities.h"
 

LEGO1/omni/src/system/mxautolock.cpp

@@ -1,5 +1,7 @@
 #include "mxautolock.h"
 
+#include "mxcriticalsection.h"
+
 // FUNCTION: LEGO1 0x100b8ed0
 MxAutoLock::MxAutoLock(MxCriticalSection* p_criticalSection)
 {

LEGO1/omni/src/video/mxbitmap.cpp

@@ -1,6 +1,7 @@
 #include "mxbitmap.h"
 
 #include "decomp.h"
+#include "mxpalette.h"
 #include "mxutilities.h"
 
 DECOMP_SIZE_ASSERT(MxBitmap, 0x20);

LEGO1/omni/src/video/mxdisplaysurface.cpp

@@ -1,7 +1,9 @@
 #include "mxdisplaysurface.h"
 
+#include "mxbitmap.h"
 #include "mxmisc.h"
 #include "mxomni.h"
+#include "mxpalette.h"
 #include "mxutilities.h"
 #include "mxvideomanager.h"
 

LEGO1/omni/src/video/mxloopingflcpresenter.cpp

@@ -1,6 +1,8 @@
 #include "mxloopingflcpresenter.h"
 
 #include "decomp.h"
+#include "mxdsaction.h"
+#include "mxdssubscriber.h"
 
 DECOMP_SIZE_ASSERT(MxLoopingFlcPresenter, 0x6c);
 

LEGO1/omni/src/video/mxloopingsmkpresenter.cpp

@@ -2,6 +2,7 @@
 
 #include "mxautolock.h"
 #include "mxdsmediaaction.h"
+#include "mxdssubscriber.h"
 
 DECOMP_SIZE_ASSERT(MxLoopingSmkPresenter, 0x724);
 

LEGO1/omni/src/video/mxsmack.cpp

@@ -1,5 +1,7 @@
 #include "mxsmack.h"
 
+#include "mxbitmap.h"
+
 #include <string.h>
 
 DECOMP_SIZE_ASSERT(SmackTag, 0x390);

LEGO1/omni/src/video/mxsmkpresenter.cpp

@@ -3,6 +3,7 @@
 #include "decomp.h"
 #include "mxdsmediaaction.h"
 #include "mxmisc.h"
+#include "mxpalette.h"
 #include "mxvideomanager.h"
 
 DECOMP_SIZE_ASSERT(MxSmkPresenter, 0x720);

LEGO1/omni/src/video/mxstillpresenter.cpp

@@ -3,9 +3,12 @@
 #include "decomp.h"
 #include "define.h"
 #include "mxcompositepresenter.h"
+#include "mxdisplaysurface.h"
 #include "mxdsmediaaction.h"
+#include "mxdssubscriber.h"
 #include "mxmisc.h"
 #include "mxomni.h"
+#include "mxpalette.h"
 #include "mxutilities.h"
 #include "mxvideomanager.h"
 

LEGO1/omni/src/video/mxvideomanager.cpp

@@ -1,9 +1,13 @@
 #include "mxvideomanager.h"
 
 #include "mxautolock.h"
+#include "mxdisplaysurface.h"
 #include "mxmisc.h"
 #include "mxomni.h"
+#include "mxpalette.h"
 #include "mxpresenter.h"
+#include "mxregion.h"
+#include "mxthread.h"
 #include "mxticklemanager.h"
 
 DECOMP_SIZE_ASSERT(MxVideoManager, 0x64)

LEGO1/omni/src/video/mxvideopresenter.cpp

@@ -1,7 +1,9 @@
 #include "mxvideopresenter.h"
 
 #include "mxautolock.h"
+#include "mxdisplaysurface.h"
 #include "mxdsmediaaction.h"
+#include "mxdssubscriber.h"
 #include "mxmisc.h"
 #include "mxregioncursor.h"
 #include "mxvideomanager.h"