Refactor files based on beta debug build (#645)

* Rename LegoUnkSaveDataWriter -> LegoCharacterManager

* Refactor mxomni into mxomni/mxmisc

* Refactor legoomni into legoomni/misc

* Resolve deps

* Refactor atom

* Refactor mxutil

* Refactor mxio

* Rename/relocate files

* Fix format

LEGO1/omni/src/action/mxdsaction.cpp

@@ -1,8 +1,8 @@
 #include "mxdsaction.h"
 
-#include "mxomni.h"
+#include "mxmisc.h"
 #include "mxtimer.h"
-#include "mxutil.h"
+#include "mxutilities.h"
 
 #include <float.h>
 #include <limits.h>

LEGO1/omni/src/action/mxdsmediaaction.cpp

@@ -1,6 +1,6 @@
 #include "mxdsmediaaction.h"
 
-#include "mxutil.h"
+#include "mxutilities.h"
 
 DECOMP_SIZE_ASSERT(MxDSMediaAction, 0xb8)
 

LEGO1/omni/src/action/mxdsobject.cpp

@@ -11,7 +11,7 @@
 #include "mxdsserialaction.h"
 #include "mxdssound.h"
 #include "mxdsstill.h"
-#include "mxutil.h"
+#include "mxutilities.h"
 
 #include <stdlib.h>
 #include <string.h>

LEGO1/omni/src/action/mxdsselectaction.cpp

@@ -1,6 +1,6 @@
 #include "mxdsselectaction.h"
 
-#include "mxomni.h"
+#include "mxmisc.h"
 #include "mxtimer.h"
 #include "mxvariabletable.h"
 

LEGO1/omni/src/action/mxdssound.cpp

@@ -1,6 +1,6 @@
 #include "mxdssound.h"
 
-#include "mxutil.h"
+#include "mxutilities.h"
 
 DECOMP_SIZE_ASSERT(MxDSSound, 0xc0)
 

LEGO1/omni/src/audio/mxloopingmidipresenter.cpp

@@ -2,8 +2,8 @@
 
 #include "decomp.h"
 #include "mxdssound.h"
+#include "mxmisc.h"
 #include "mxmusicmanager.h"
-#include "mxomni.h"
 
 DECOMP_SIZE_ASSERT(MxLoopingMIDIPresenter, 0x58);
 

LEGO1/omni/src/audio/mxmidipresenter.cpp

@@ -3,6 +3,7 @@
 #include "decomp.h"
 #include "mxautolocker.h"
 #include "mxdssound.h"
+#include "mxmisc.h"
 #include "mxmusicmanager.h"
 
 DECOMP_SIZE_ASSERT(MxMIDIPresenter, 0x58);

LEGO1/omni/src/audio/mxmusicmanager.cpp

@@ -1,6 +1,6 @@
 #include "mxmusicmanager.h"
 
-#include "mxomni.h"
+#include "mxmisc.h"
 #include "mxticklemanager.h"
 
 #include <windows.h>

LEGO1/omni/src/audio/mxmusicpresenter.cpp

@@ -1,8 +1,8 @@
 #include "mxmusicpresenter.h"
 
 #include "decomp.h"
+#include "mxmisc.h"
 #include "mxmusicmanager.h"
-#include "mxomni.h"
 
 DECOMP_SIZE_ASSERT(MxMusicPresenter, 0x54);
 

LEGO1/omni/src/audio/mxsoundmanager.cpp

@@ -2,6 +2,7 @@
 
 #include "define.h"
 #include "mxautolocker.h"
+#include "mxmisc.h"
 #include "mxomni.h"
 #include "mxpresenter.h"
 #include "mxticklemanager.h"

LEGO1/omni/src/audio/mxsoundpresenter.cpp

@@ -1,6 +1,7 @@
 #include "mxsoundpresenter.h"
 
 #include "decomp.h"
+#include "mxmisc.h"
 #include "mxsoundmanager.h"
 
 DECOMP_SIZE_ASSERT(MxSoundPresenter, 0x54)

LEGO1/omni/src/audio/mxwavepresenter.cpp

@@ -4,9 +4,10 @@
 #include "define.h"
 #include "mxautolocker.h"
 #include "mxdssound.h"
+#include "mxmisc.h"
 #include "mxomni.h"
 #include "mxsoundmanager.h"
-#include "mxutil.h"
+#include "mxutilities.h"
 
 DECOMP_SIZE_ASSERT(MxWavePresenter, 0x6c);
 DECOMP_SIZE_ASSERT(MxWavePresenter::WaveFormat, 0x18);

LEGO1/omni/src/common/mxatom.cpp

@@ -1,7 +1,13 @@
-#include "mxatomid.h"
+#include "mxatom.h"
 
+#include "decomp.h"
+#include "mxmisc.h"
 #include "mxomni.h"
 
+DECOMP_SIZE_ASSERT(MxAtomId, 0x04);
+DECOMP_SIZE_ASSERT(MxAtomIdCounter, 0x14);
+DECOMP_SIZE_ASSERT(MxAtomIdCounterSet, 0x10);
+
 // FUNCTION: LEGO1 0x100acf90
 MxAtomId::MxAtomId(const char* p_str, LookupMode p_mode)
 {
@@ -107,3 +113,17 @@ void MxAtomId::Clear()
 	Destroy();
 	m_internal = NULL;
 }
+
+// FUNCTION: LEGO1 0x100ad7f0
+void MxAtomIdCounter::Inc()
+{
+	m_value++;
+}
+
+// FUNCTION: LEGO1 0x100ad800
+void MxAtomIdCounter::Dec()
+{
+	if (m_value) {
+		m_value--;
+	}
+}

LEGO1/omni/src/common/mxatomidcounter.cpp

@@ -1,20 +0,0 @@
-#include "mxatomidcounter.h"
-
-#include "decomp.h"
-
-DECOMP_SIZE_ASSERT(MxAtomIdCounter, 0x14);
-DECOMP_SIZE_ASSERT(MxAtomIdCounterSet, 0x10);
-
-// FUNCTION: LEGO1 0x100ad7f0
-void MxAtomIdCounter::Inc()
-{
-	m_value++;
-}
-
-// FUNCTION: LEGO1 0x100ad800
-void MxAtomIdCounter::Dec()
-{
-	if (m_value) {
-		m_value--;
-	}
-}

LEGO1/omni/src/common/mxcompositepresenter.cpp

@@ -3,6 +3,7 @@
 #include "decomp.h"
 #include "mxautolocker.h"
 #include "mxdsmultiaction.h"
+#include "mxmisc.h"
 #include "mxnotificationmanager.h"
 #include "mxobjectfactory.h"
 

LEGO1/omni/src/common/mxmediapresenter.cpp

@@ -3,6 +3,7 @@
 #include "mxactionnotificationparam.h"
 #include "mxautolocker.h"
 #include "mxcompositepresenter.h"
+#include "mxmisc.h"
 #include "mxnotificationmanager.h"
 #include "mxstreamchunk.h"
 #include "mxtimer.h"

LEGO1/omni/src/common/mxmisc.cpp

@@ -0,0 +1,81 @@
+#include "mxmisc.h"
+
+#include "mxomni.h"
+
+// FUNCTION: LEGO1 0x100acea0
+MxObjectFactory* ObjectFactory()
+{
+	return MxOmni::GetInstance()->GetObjectFactory();
+}
+
+// FUNCTION: LEGO1 0x100aceb0
+MxNotificationManager* NotificationManager()
+{
+	return MxOmni::GetInstance()->GetNotificationManager();
+}
+
+// FUNCTION: LEGO1 0x100acec0
+MxTickleManager* TickleManager()
+{
+	return MxOmni::GetInstance()->GetTickleManager();
+}
+
+// FUNCTION: LEGO1 0x100aced0
+MxTimer* Timer()
+{
+	return MxOmni::GetInstance()->GetTimer();
+}
+
+// FUNCTION: LEGO1 0x100acee0
+MxAtomIdCounterSet* AtomIdCounterSet()
+{
+	return MxOmni::GetInstance()->GetAtomIdCounterSet();
+}
+
+// FUNCTION: LEGO1 0x100acef0
+MxStreamer* Streamer()
+{
+	return MxOmni::GetInstance()->GetStreamer();
+}
+
+// FUNCTION: LEGO1 0x100acf00
+MxSoundManager* MSoundManager()
+{
+	return MxOmni::GetInstance()->GetSoundManager();
+}
+
+// FUNCTION: LEGO1 0x100acf10
+MxVideoManager* MVideoManager()
+{
+	return MxOmni::GetInstance()->GetVideoManager();
+}
+
+// FUNCTION: LEGO1 0x100acf20
+MxVariableTable* VariableTable()
+{
+	return MxOmni::GetInstance()->GetVariableTable();
+}
+
+// FUNCTION: LEGO1 0x100acf30
+MxMusicManager* MusicManager()
+{
+	return MxOmni::GetInstance()->GetMusicManager();
+}
+
+// FUNCTION: LEGO1 0x100acf40
+MxEventManager* EventManager()
+{
+	return MxOmni::GetInstance()->GetEventManager();
+}
+
+// FUNCTION: LEGO1 0x100acf50
+MxResult Start(MxDSAction* p_dsAction)
+{
+	return MxOmni::GetInstance()->Start(p_dsAction);
+}
+
+// FUNCTION: LEGO1 0x100acf70
+void DeleteObject(MxDSAction& p_dsAction)
+{
+	MxOmni::GetInstance()->DeleteObject(p_dsAction);
+}

LEGO1/omni/src/common/mxpresenter.cpp

@@ -8,11 +8,13 @@
 #include "mxdsanim.h"
 #include "mxdssound.h"
 #include "mxentity.h"
+#include "mxmisc.h"
 #include "mxnotificationmanager.h"
 #include "mxobjectfactory.h"
+#include "mxomni.h"
 #include "mxparam.h"
 #include "mxstreamer.h"
-#include "mxutil.h"
+#include "mxutilities.h"
 
 #include <string.h>
 

LEGO1/omni/src/common/mxticklemanager.cpp

@@ -1,7 +1,7 @@
 #include "mxticklemanager.h"
 
 #include "decomp.h"
-#include "mxomni.h"
+#include "mxmisc.h"
 #include "mxtimer.h"
 #include "mxtypes.h"
 

LEGO1/omni/src/common/mxutilities.cpp

@@ -1,4 +1,4 @@
-#include "mxutil.h"
+#include "mxutilities.h"
 
 #include "mxcompositepresenter.h"
 #include "mxdsaction.h"

LEGO1/omni/src/event/mxeventmanager.cpp

@@ -1,7 +1,7 @@
 #include "mxeventmanager.h"
 
 #include "mxcriticalsection.h"
-#include "mxomni.h"
+#include "mxmisc.h"
 #include "mxthread.h"
 #include "mxticklemanager.h"
 

LEGO1/omni/src/event/mxeventpresenter.cpp

@@ -3,7 +3,7 @@
 #include "decomp.h"
 #include "mxautolocker.h"
 #include "mxeventmanager.h"
-#include "mxomni.h"
+#include "mxmisc.h"
 #include "mxvariabletable.h"
 
 DECOMP_SIZE_ASSERT(MxEventPresenter, 0x54);

LEGO1/omni/src/main/mxomni.cpp

@@ -1,10 +1,11 @@
 #include "mxomni.h"
 
 #include "mxactionnotificationparam.h"
-#include "mxatomidcounter.h"
+#include "mxatom.h"
 #include "mxautolocker.h"
 #include "mxdsmultiaction.h"
 #include "mxeventmanager.h"
+#include "mxmisc.h"
 #include "mxmusicmanager.h"
 #include "mxnotificationmanager.h"
 #include "mxobjectfactory.h"
@@ -28,84 +29,6 @@ MxBool g_use3dSound = FALSE;
 // GLOBAL: LEGO1 0x101015b0
 MxOmni* MxOmni::g_instance = NULL;
 
-// FUNCTION: LEGO1 0x100acea0
-MxObjectFactory* ObjectFactory()
-{
-	return MxOmni::GetInstance()->GetObjectFactory();
-}
-
-// FUNCTION: LEGO1 0x100aceb0
-MxNotificationManager* NotificationManager()
-{
-	return MxOmni::GetInstance()->GetNotificationManager();
-}
-
-// FUNCTION: LEGO1 0x100acec0
-MxTickleManager* TickleManager()
-{
-	return MxOmni::GetInstance()->GetTickleManager();
-}
-
-// FUNCTION: LEGO1 0x100aced0
-MxTimer* Timer()
-{
-	return MxOmni::GetInstance()->GetTimer();
-}
-
-// FUNCTION: LEGO1 0x100acee0
-MxAtomIdCounterSet* AtomIdCounterSet()
-{
-	return MxOmni::GetInstance()->GetAtomIdCounterSet();
-}
-
-// FUNCTION: LEGO1 0x100acef0
-MxStreamer* Streamer()
-{
-	return MxOmni::GetInstance()->GetStreamer();
-}
-
-// FUNCTION: LEGO1 0x100acf00
-MxSoundManager* MSoundManager()
-{
-	return MxOmni::GetInstance()->GetSoundManager();
-}
-
-// FUNCTION: LEGO1 0x100acf10
-MxVideoManager* MVideoManager()
-{
-	return MxOmni::GetInstance()->GetVideoManager();
-}
-
-// FUNCTION: LEGO1 0x100acf20
-MxVariableTable* VariableTable()
-{
-	return MxOmni::GetInstance()->GetVariableTable();
-}
-
-// FUNCTION: LEGO1 0x100acf30
-MxMusicManager* MusicManager()
-{
-	return MxOmni::GetInstance()->GetMusicManager();
-}
-
-// FUNCTION: LEGO1 0x100acf40
-MxEventManager* EventManager()
-{
-	return MxOmni::GetInstance()->GetEventManager();
-}
-
-// FUNCTION: LEGO1 0x100acf50
-MxResult Start(MxDSAction* p_dsAction)
-{
-	return MxOmni::GetInstance()->Start(p_dsAction);
-}
-
-// FUNCTION: LEGO1 0x100acf70
-void DeleteObject(MxDSAction& p_dsAction)
-{
-	MxOmni::GetInstance()->DeleteObject(p_dsAction);
-}
-
 // FUNCTION: LEGO1 0x100aef10
 MxOmni::MxOmni()
 {

LEGO1/omni/src/notify/mxnotificationmanager.cpp

@@ -3,7 +3,7 @@
 #include "compat.h"
 #include "decomp.h"
 #include "mxautolocker.h"
-#include "mxomni.h"
+#include "mxmisc.h"
 #include "mxparam.h"
 #include "mxticklemanager.h"
 #include "mxtypes.h"

LEGO1/omni/src/stream/mxdiskstreamcontroller.cpp

@@ -4,6 +4,7 @@
 #include "mxautolocker.h"
 #include "mxdiskstreamprovider.h"
 #include "mxdsstreamingaction.h"
+#include "mxmisc.h"
 #include "mxomni.h"
 #include "mxticklemanager.h"
 

LEGO1/omni/src/stream/mxdsbuffer.cpp

@@ -3,6 +3,7 @@
 #include "mxdiskstreamcontroller.h"
 #include "mxdschunk.h"
 #include "mxdsstreamingaction.h"
+#include "mxmisc.h"
 #include "mxomni.h"
 #include "mxstreamchunk.h"
 #include "mxstreamcontroller.h"

LEGO1/omni/src/stream/mxio.cpp

@@ -1,4 +1,4 @@
-#include "mxioinfo.h"
+#include "mxio.h"
 
 #include "decomp.h"
 

LEGO1/omni/src/stream/mxstreamchunk.cpp

@@ -2,7 +2,7 @@
 
 #include "mxdsbuffer.h"
 #include "mxstreamlist.h"
-#include "mxutil.h"
+#include "mxutilities.h"
 
 // FUNCTION: LEGO1 0x100c2fe0
 MxStreamChunk::~MxStreamChunk()

LEGO1/omni/src/stream/mxstreamcontroller.cpp

@@ -3,12 +3,12 @@
 #include "mxautolocker.h"
 #include "mxdsmultiaction.h"
 #include "mxdsstreamingaction.h"
+#include "mxmisc.h"
 #include "mxnextactiondatastart.h"
-#include "mxomni.h"
 #include "mxstl/stlcompat.h"
 #include "mxstreamchunk.h"
 #include "mxtimer.h"
-#include "mxutil.h"
+#include "mxutilities.h"
 
 DECOMP_SIZE_ASSERT(MxStreamController, 0x64)
 DECOMP_SIZE_ASSERT(MxNextActionDataStart, 0x14)

LEGO1/omni/src/stream/mxstreamer.cpp

@@ -1,8 +1,8 @@
 #include "mxstreamer.h"
 
 #include "mxdiskstreamcontroller.h"
+#include "mxmisc.h"
 #include "mxnotificationmanager.h"
-#include "mxomni.h"
 #include "mxramstreamcontroller.h"
 
 #include <algorithm>

LEGO1/omni/src/system/mxthread.cpp

@@ -1,7 +1,7 @@
 #include "mxthread.h"
 
 #include "decomp.h"
-#include "mxomni.h"
+#include "mxmisc.h"
 #include "mxtimer.h"
 
 #include <process.h>

LEGO1/omni/src/video/mxbitmap.cpp

@@ -1,7 +1,7 @@
 #include "mxbitmap.h"
 
 #include "decomp.h"
-#include "mxutil.h"
+#include "mxutilities.h"
 
 DECOMP_SIZE_ASSERT(MxBitmap, 0x20);
 DECOMP_SIZE_ASSERT(MxBITMAPINFO, 0x428);

LEGO1/omni/src/video/mxdisplaysurface.cpp

@@ -1,6 +1,8 @@
 #include "mxdisplaysurface.h"
 
-#include "mxutil.h"
+#include "mxmisc.h"
+#include "mxomni.h"
+#include "mxutilities.h"
 #include "mxvideomanager.h"
 
 #include <windows.h>

LEGO1/omni/src/video/mxflcpresenter.cpp

@@ -3,7 +3,7 @@
 #include "decomp.h"
 #include "mxbitmap.h"
 #include "mxdsmediaaction.h"
-#include "mxomni.h"
+#include "mxmisc.h"
 #include "mxpalette.h"
 #include "mxvideomanager.h"
 

LEGO1/omni/src/video/mxpalette.cpp

@@ -1,6 +1,6 @@
 #include "mxpalette.h"
 
-#include "mxomni.h"
+#include "mxmisc.h"
 #include "mxvideomanager.h"
 
 // GLOBAL: LEGO1 0x10102188

LEGO1/omni/src/video/mxsmkpresenter.cpp

@@ -2,6 +2,7 @@
 
 #include "decomp.h"
 #include "mxdsmediaaction.h"
+#include "mxmisc.h"
 #include "mxvideomanager.h"
 
 DECOMP_SIZE_ASSERT(MxSmkPresenter, 0x720);

LEGO1/omni/src/video/mxstillpresenter.cpp

@@ -4,8 +4,9 @@
 #include "define.h"
 #include "mxcompositepresenter.h"
 #include "mxdsmediaaction.h"
+#include "mxmisc.h"
 #include "mxomni.h"
-#include "mxutil.h"
+#include "mxutilities.h"
 #include "mxvideomanager.h"
 
 DECOMP_SIZE_ASSERT(MxStillPresenter, 0x6c);

LEGO1/omni/src/video/mxvideomanager.cpp

@@ -1,6 +1,8 @@
 #include "mxvideomanager.h"
 
 #include "mxautolocker.h"
+#include "mxmisc.h"
+#include "mxomni.h"
 #include "mxpresenter.h"
 #include "mxticklemanager.h"
 

LEGO1/omni/src/video/mxvideopresenter.cpp

@@ -2,6 +2,7 @@
 
 #include "mxautolocker.h"
 #include "mxdsmediaaction.h"
+#include "mxmisc.h"
 #include "mxregioncursor.h"
 #include "mxvideomanager.h"