Implement the rest of the SkateBoard class (#873)

* Implement SkateBoard::~SkateBoard()

* Implement SkateBoard::VTable0xd4

* Implement SkateBoard::Create()

- one typecast is still not clear

* Add SkateBoard::VTable0xe4()

* apply clang-format

* Apply clang-format to legocontrolmanager.h

* Address review comments

* 57 percent match

* 63 percent

* 82 percent match

* previous 86 was bugged, unfortunately

* 85 percent on FUN_10010270

* 92 percent FUN_10010270

* 69 percent VTable0xcc

* 73 percent VTable0xcc

* more progress, not quite there yet

* minor 10010510 improvement

* 100 % on FUN_10010510

* slowly making progress on SkateBoard::VTable0xcc (broken decomp)

* getting closer, now only wrong registers

* 89 percent VTable0xcc

* 92 percent

* 95 % VTable0xcc

* Changes, see comment

---------

Co-authored-by: jonschz <jonschz@users.noreply.github.com>
Co-authored-by: Christian Semmler <mail@csemmler.com>
This commit is contained in:
jonschz
2024-05-01 13:36:58 +02:00
committed by GitHub
parent 20dee07b9c
commit 84b789ef9e
11 changed files with 119 additions and 50 deletions

View File

@@ -849,7 +849,7 @@ MxResult LegoAnimationManager::FUN_10060dc0(
IsleScript::Script p_objectId,
MxMatrix* p_matrix,
MxBool p_param3,
undefined p_param4,
MxBool p_param4,
LegoROI* p_roi,
MxBool p_param6,
MxBool p_param7,
@@ -870,10 +870,10 @@ MxResult LegoAnimationManager::FUN_10060dc0(
MxBool unk0x0a;
switch (p_param4) {
case 0:
case FALSE:
unk0x0a = m_anims[i].m_unk0x0a;
break;
case 1:
case TRUE:
unk0x0a = TRUE;
break;
default:
@@ -1040,13 +1040,13 @@ void LegoAnimationManager::FUN_10063aa0()
}
// STUB: LEGO1 0x10064670
void LegoAnimationManager::FUN_10064670(MxBool)
void LegoAnimationManager::FUN_10064670(Vector3*)
{
// TODO
}
// STUB: LEGO1 0x10064740
void LegoAnimationManager::FUN_10064740(MxBool)
void LegoAnimationManager::FUN_10064740(Vector3*)
{
// TODO
}