mirror of
https://github.com/isledecomp/isle.git
synced 2025-10-22 16:04:17 +00:00
cmake+ci: run clang-tidy (#512)
* cmake+ci: run clang-tidy
* Remove DESCRIPTION from LEGO1/LegoOmni.mingw.def
* Add initial .clang-tidy and fixes
* fix file perms
* Comment out DESCRIPTION
* Remove LegoEntity::~LegoEntity and MxPresenter::~MxPresenter from mingw's LEGO1.def
* Looks like clang is allergic to the libs in the directx5 SDK
* Update .clang-tidy
* Fix typo in .clang-tidy
* Attempt to generate an action error
* Revert "Attempt to generate an action error"
This reverts commit 96c4c65fed
.
* cmake: test with -Wparentheses + optionally with -Werror
* ci: -k0 is a Ninja argument
* Use -Werror only for msys2 builds
* cmake: only emit warnings for specific warnings
* cmake: and don't do -Werror/-WX anymore
* Fix warnings
* Fix mingw warnings
---------
Co-authored-by: Christian Semmler <mail@csemmler.com>
This commit is contained in:

committed by
GitHub

parent
97d1ba7c71
commit
9e686e2a87
@@ -42,7 +42,7 @@ class LegoEventQueue : public MxQueue<LegoEventNotificationParam> {};
|
||||
class LegoNotifyList : public MxPtrList<MxCore> {
|
||||
protected:
|
||||
// FUNCTION: LEGO1 0x10028830
|
||||
virtual MxS8 Compare(MxCore* p_element1, MxCore* p_element2) override
|
||||
MxS8 Compare(MxCore* p_element1, MxCore* p_element2) override
|
||||
{
|
||||
return p_element1 == p_element2 ? 0 : p_element1 < p_element2 ? -1 : 1;
|
||||
} // vtable+0x14
|
||||
@@ -69,19 +69,19 @@ public:
|
||||
class LegoInputManager : public MxPresenter {
|
||||
public:
|
||||
LegoInputManager();
|
||||
virtual ~LegoInputManager() override;
|
||||
~LegoInputManager() override;
|
||||
|
||||
void QueueEvent(NotificationId p_id, MxU8 p_modifier, MxLong p_x, MxLong p_y, MxU8 p_key);
|
||||
void Register(MxCore*);
|
||||
void UnRegister(MxCore*);
|
||||
|
||||
virtual MxResult Tickle() override; // vtable+0x08
|
||||
MxResult Tickle() override; // vtable+0x08
|
||||
|
||||
// FUNCTION: LEGO1 0x1005b8c0
|
||||
virtual MxResult PutData() override { return SUCCESS; } // vtable+0x4c
|
||||
MxResult PutData() override { return SUCCESS; } // vtable+0x4c
|
||||
|
||||
MxResult Create(HWND p_hwnd);
|
||||
void Destroy();
|
||||
void Destroy() override;
|
||||
void CreateAndAcquireKeyboard(HWND p_hwnd);
|
||||
void ReleaseDX();
|
||||
MxResult GetJoystickId();
|
||||
|
Reference in New Issue
Block a user