cmake+ci: run clang-tidy (#512)

* cmake+ci: run clang-tidy

* Remove DESCRIPTION from LEGO1/LegoOmni.mingw.def

* Add initial .clang-tidy and fixes

* fix file perms

* Comment out DESCRIPTION

* Remove LegoEntity::~LegoEntity and MxPresenter::~MxPresenter from mingw's LEGO1.def

* Looks like clang is allergic to the libs in the directx5 SDK

* Update .clang-tidy

* Fix typo in .clang-tidy

* Attempt to generate an action error

* Revert "Attempt to generate an action error"

This reverts commit 96c4c65fed.

* cmake: test with -Wparentheses + optionally with -Werror

* ci: -k0 is a Ninja argument

* Use -Werror only for msys2 builds

* cmake: only emit warnings for specific warnings

* cmake: and don't do -Werror/-WX anymore

* Fix warnings

* Fix mingw warnings

---------

Co-authored-by: Christian Semmler <mail@csemmler.com>
This commit is contained in:
Anonymous Maarten
2024-02-01 21:42:10 +01:00
committed by GitHub
parent 97d1ba7c71
commit 9e686e2a87
308 changed files with 2863 additions and 1995 deletions

View File

@@ -29,8 +29,9 @@ Lego3DView::~Lego3DView()
BOOL Lego3DView::Create(const TglSurface::CreateStruct& rCreateStruct, Tgl::Renderer* pRenderer)
{
double viewAngle = 45;
if (rCreateStruct.m_isWideViewAngle)
if (rCreateStruct.m_isWideViewAngle) {
viewAngle = 90;
}
float frontClippingDistance = 0.1;
float backClippingDistance = 500;

View File

@@ -13,10 +13,10 @@
class Lego3DView : public LegoView1 {
public:
Lego3DView();
virtual ~Lego3DView() override;
~Lego3DView() override;
BOOL Create(const CreateStruct&, Tgl::Renderer*);
virtual void Destroy() override; // vtable+0x08
void Destroy() override; // vtable+0x08
BOOL Add(ViewROI&);
BOOL Remove(ViewROI&);

View File

@@ -42,8 +42,9 @@ LegoView::~LegoView()
BOOL LegoView::Create(const TglSurface::CreateStruct& rCreateStruct, Tgl::Renderer* pRenderer)
{
float viewAngle = 45;
if (rCreateStruct.m_isWideViewAngle)
if (rCreateStruct.m_isWideViewAngle) {
viewAngle = 90;
}
float frontClippingDistance = 0.1;
float backClippingDistance = 500;

View File

@@ -18,16 +18,16 @@ class Camera;
class LegoView : public TglSurface {
public:
LegoView();
virtual ~LegoView() override;
~LegoView() override;
BOOL Create(const CreateStruct&, Tgl::Renderer*);
virtual void Destroy() override; // vtable+0x08
void Destroy() override; // vtable+0x08
Tgl::Group* GetScene() const;
Tgl::Camera* GetCamera() const;
protected:
virtual Tgl::View* CreateView(Tgl::Renderer*, Tgl::Device*); // vtable+0x10
Tgl::View* CreateView(Tgl::Renderer*, Tgl::Device*) override; // vtable+0x10
private:
Tgl::Group* m_pScene; // 0x70
@@ -58,11 +58,11 @@ inline Tgl::Camera* LegoView::GetCamera() const
class LegoView1 : public LegoView {
public:
LegoView1();
virtual ~LegoView1() override;
~LegoView1() override;
BOOL AddLightsToViewport();
BOOL Create(const TglSurface::CreateStruct&, Tgl::Renderer*);
virtual void Destroy() override; // vtable+0x08
void Destroy() override; // vtable+0x08
private:
Tgl::Light* m_pSunLight; // 0x78