mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-25 09:24:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmake+ci: run clang-tidy (#512)

Browse Source 
* cmake+ci: run clang-tidy

* Remove DESCRIPTION from LEGO1/LegoOmni.mingw.def

* Add initial .clang-tidy and fixes

* fix file perms

* Comment out DESCRIPTION

* Remove LegoEntity::~LegoEntity and MxPresenter::~MxPresenter from mingw's LEGO1.def

* Looks like clang is allergic to the libs in the directx5 SDK

* Update .clang-tidy

* Fix typo in .clang-tidy

* Attempt to generate an action error

* Revert "Attempt to generate an action error"

This reverts commit 96c4c65fed.

* cmake: test with -Wparentheses + optionally with -Werror

* ci: -k0 is a Ninja argument

* Use -Werror only for msys2 builds

* cmake: only emit warnings for specific warnings

* cmake: and don't do -Werror/-WX anymore

* Fix warnings

* Fix mingw warnings

---------

Co-authored-by: Christian Semmler <mail@csemmler.com>
This commit is contained in:
Anonymous Maarten
2024-02-01 21:42:10 +01:00
committed by GitHub
parent 97d1ba7c71
commit 9e686e2a87
308 changed files with 2863 additions and 1995 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
LEGO1/omni/src/common/mxpresenter.cpp
View File

@@ -49,8 +49,9 @@ MxResult MxPresenter::StartAction(MxStreamController*, MxDSAction* p_action)
// FUNCTION: LEGO1 0x100b4e40
void MxPresenter::EndAction()
{
if (this->m_action == NULL)
if (this->m_action == NULL) {
return;
}
MxAutoLocker lock(&this->m_criticalSection);
@@ -98,8 +99,9 @@ void MxPresenter::ParseExtra()
m_action->SetFlags(m_action->GetFlags() | MxDSAction::c_world);
if (result)
if (result) {
SendToCompositePresenter(MxOmni::GetInstance());
}
}
}
}
@@ -133,28 +135,33 @@ MxResult MxPresenter::Tickle()
case e_ready:
this->ReadyTickle();
if (m_currentTickleState != e_starting)
if (m_currentTickleState != e_starting) {
break;
}
case e_starting:
this->StartingTickle();
if (m_currentTickleState != e_streaming)
if (m_currentTickleState != e_streaming) {
break;
}
case e_streaming:
this->StreamingTickle();
if (m_currentTickleState != e_repeating)
if (m_currentTickleState != e_repeating) {
break;
}
case e_repeating:
this->RepeatingTickle();
if (m_currentTickleState != e_unk5)
if (m_currentTickleState != e_unk5) {
break;
}
case e_unk5:
this->Unk5Tickle();
if (m_currentTickleState != e_done)
if (m_currentTickleState != e_done) {
break;
}
case e_done:
this->DoneTickle();
default:
@@ -170,10 +177,12 @@ void MxPresenter::Enable(MxBool p_enable)
if (this->m_action && this->IsEnabled() != p_enable) {
MxU32 flags = this->m_action->GetFlags();
if (p_enable)
if (p_enable) {
this->m_action->SetFlags(flags | MxDSAction::c_enabled);
else
}
else {
this->m_action->SetFlags(flags & ~MxDSAction::c_enabled);
}
}
}