mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-25 09:24:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmake+ci: run clang-tidy (#512)

Browse Source 
* cmake+ci: run clang-tidy

* Remove DESCRIPTION from LEGO1/LegoOmni.mingw.def

* Add initial .clang-tidy and fixes

* fix file perms

* Comment out DESCRIPTION

* Remove LegoEntity::~LegoEntity and MxPresenter::~MxPresenter from mingw's LEGO1.def

* Looks like clang is allergic to the libs in the directx5 SDK

* Update .clang-tidy

* Fix typo in .clang-tidy

* Attempt to generate an action error

* Revert "Attempt to generate an action error"

This reverts commit 96c4c65fed.

* cmake: test with -Wparentheses + optionally with -Werror

* ci: -k0 is a Ninja argument

* Use -Werror only for msys2 builds

* cmake: only emit warnings for specific warnings

* cmake: and don't do -Werror/-WX anymore

* Fix warnings

* Fix mingw warnings

---------

Co-authored-by: Christian Semmler <mail@csemmler.com>
This commit is contained in:
Anonymous Maarten
2024-02-01 21:42:10 +01:00
committed by GitHub
parent 97d1ba7c71
commit 9e686e2a87
308 changed files with 2863 additions and 1995 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
LEGO1/omni/src/event/mxeventmanager.cpp
View File

@@ -30,11 +30,13 @@ void MxEventManager::Destroy(MxBool p_fromDestructor)
m_thread->Terminate();
delete m_thread;
}
else
else {
TickleManager()->UnregisterClient(this);
}
if (!p_fromDestructor)
if (!p_fromDestructor) {
MxMediaManager::Destroy();
}
}
// FUNCTION: LEGO1 0x100c04a0
@@ -50,21 +52,25 @@ MxResult MxEventManager::Create(MxU32 p_frequencyMS, MxBool p_createThread)
locked = TRUE;
this->m_thread = new MxTickleThread(this, p_frequencyMS);
if (!this->m_thread || this->m_thread->Start(0, 0) != SUCCESS)
if (!this->m_thread || this->m_thread->Start(0, 0) != SUCCESS) {
goto done;
}
}
else
else {
TickleManager()->RegisterClient(this, p_frequencyMS);
}
status = SUCCESS;
}
done:
if (status != SUCCESS)
if (status != SUCCESS) {
Destroy();
}
if (locked)
if (locked) {
this->m_criticalSection.Leave();
}
return status;
}

12
LEGO1/omni/src/event/mxeventpresenter.cpp
View File

@@ -42,13 +42,15 @@ MxResult MxEventPresenter::AddToManager()
// FUNCTION: LEGO1 0x100c2de0
void MxEventPresenter::Destroy()
{
if (EventManager())
if (EventManager()) {
EventManager()->UnregisterPresenter(*this);
}
m_criticalSection.Enter();
if (m_data)
if (m_data) {
delete[] m_data;
}
Init();
@@ -80,8 +82,9 @@ void MxEventPresenter::StartingTickle()
{
MxStreamChunk* chunk = CurrentChunk();
if (chunk && m_action->GetElapsedTime() >= chunk->GetTime())
if (chunk && m_action->GetElapsedTime() >= chunk->GetTime()) {
ProgressTickleState(e_streaming);
}
}
// FUNCTION: LEGO1 0x100c2ef0
@@ -103,8 +106,9 @@ MxResult MxEventPresenter::PutData()
variableTable->SetVariable(key, value);
}
if (m_currentTickleState == e_streaming)
if (m_currentTickleState == e_streaming) {
m_subscriber->DestroyChunk(m_currentChunk);
}
m_currentChunk = NULL;
}
}