mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 00:14:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmake+ci: run clang-tidy (#512)

Browse Source 
* cmake+ci: run clang-tidy

* Remove DESCRIPTION from LEGO1/LegoOmni.mingw.def

* Add initial .clang-tidy and fixes

* fix file perms

* Comment out DESCRIPTION

* Remove LegoEntity::~LegoEntity and MxPresenter::~MxPresenter from mingw's LEGO1.def

* Looks like clang is allergic to the libs in the directx5 SDK

* Update .clang-tidy

* Fix typo in .clang-tidy

* Attempt to generate an action error

* Revert "Attempt to generate an action error"

This reverts commit 96c4c65fed.

* cmake: test with -Wparentheses + optionally with -Werror

* ci: -k0 is a Ninja argument

* Use -Werror only for msys2 builds

* cmake: only emit warnings for specific warnings

* cmake: and don't do -Werror/-WX anymore

* Fix warnings

* Fix mingw warnings

---------

Co-authored-by: Christian Semmler <mail@csemmler.com>
This commit is contained in:
Anonymous Maarten
2024-02-01 21:42:10 +01:00
committed by GitHub
parent 97d1ba7c71
commit 9e686e2a87
308 changed files with 2863 additions and 1995 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
LEGO1/realtime/matrix.h
View File

@@ -64,8 +64,9 @@ public:
// FUNCTION: LEGO1 0x10002430
virtual Matrix4& operator+=(float (*p_data)[4])
{
for (int i = 0; i < 16; i++)
for (int i = 0; i < 16; i++) {
((float*) m_data)[i] += ((float*) p_data)[i];
}
return *this;
} // vtable+0x2c

3
LEGO1/realtime/orientableroi.cpp
View File

@@ -53,11 +53,12 @@ void OrientableROI::UpdateWorldData(const MxMatrix& p_transform)
UpdateWorldVelocity();
// iterate over comps
if (m_comp)
if (m_comp) {
for (CompoundObject::iterator iter = m_comp->begin(); !(iter == m_comp->end()); iter++) {
ROI* child = *iter;
static_cast<OrientableROI*>(child)->UpdateWorldData(p_transform);
}
}
}
// FUNCTION: LEGO1 0x100a5a50

6
LEGO1/realtime/orientableroi.h
View File

@@ -16,9 +16,9 @@ public:
OrientableROI();
virtual const float* GetWorldVelocity() const override; // vtable+0x08
virtual const BoundingBox& GetWorldBoundingBox() const override; // vtable+0x0c
virtual const BoundingSphere& GetWorldBoundingSphere() const override; // vtable+0x10
const float* GetWorldVelocity() const override; // vtable+0x08
const BoundingBox& GetWorldBoundingBox() const override; // vtable+0x0c
const BoundingSphere& GetWorldBoundingSphere() const override; // vtable+0x10
// FUNCTION: LEGO1 0x100a5db0
virtual void VTable0x14() { VTable0x1c(); } // vtable+0x14
virtual void UpdateWorldBoundingVolumes() = 0; // vtable+0x18

42
LEGO1/realtime/vector.h
View File

@@ -192,7 +192,7 @@ public:
// Vector2 overrides
// FUNCTION: LEGO1 0x10003a60
virtual void AddImpl(float* p_value) override
void AddImpl(float* p_value) override
{
m_data[0] += p_value[0];
m_data[1] += p_value[1];
@@ -200,7 +200,7 @@ public:
} // vtable+0x04
// FUNCTION: LEGO1 0x10003a90
virtual void AddImpl(float p_value) override
void AddImpl(float p_value) override
{
m_data[0] += p_value;
m_data[1] += p_value;
@@ -208,7 +208,7 @@ public:
} // vtable+0x00
// FUNCTION: LEGO1 0x10003ac0
virtual void SubImpl(float* p_value) override
void SubImpl(float* p_value) override
{
m_data[0] -= p_value[0];
m_data[1] -= p_value[1];
@@ -216,7 +216,7 @@ public:
} // vtable+0x08
// FUNCTION: LEGO1 0x10003b20
virtual void MulScalarImpl(float* p_value) override
void MulScalarImpl(float* p_value) override
{
m_data[0] *= *p_value;
m_data[1] *= *p_value;
@@ -224,7 +224,7 @@ public:
} // vtable+0x0c
// FUNCTION: LEGO1 0x10003af0
virtual void MulVectorImpl(float* p_value) override
void MulVectorImpl(float* p_value) override
{
m_data[0] *= p_value[0];
m_data[1] *= p_value[1];
@@ -232,7 +232,7 @@ public:
} // vtable+0x10
// FUNCTION: LEGO1 0x10003b50
virtual void DivScalarImpl(float* p_value) override
void DivScalarImpl(float* p_value) override
{
m_data[0] /= *p_value;
m_data[1] /= *p_value;
@@ -240,19 +240,19 @@ public:
} // vtable+0x14
// FUNCTION: LEGO1 0x10003b80
virtual float DotImpl(float* p_a, float* p_b) const override
float DotImpl(float* p_a, float* p_b) const override
{
return p_a[0] * p_b[0] + p_a[2] * p_b[2] + p_a[1] * p_b[1];
} // vtable+0x18
// FUNCTION: LEGO1 0x10003ba0
virtual void EqualsImpl(float* p_data) override { memcpy(m_data, p_data, sizeof(float) * 3); } // vtable+0x20
void EqualsImpl(float* p_data) override { memcpy(m_data, p_data, sizeof(float) * 3); } // vtable+0x20
// FUNCTION: LEGO1 0x10003bc0
virtual void Clear() override { memset(m_data, 0, sizeof(float) * 3); } // vtable+0x2c
void Clear() override { memset(m_data, 0, sizeof(float) * 3); } // vtable+0x2c
// FUNCTION: LEGO1 0x10003bd0
virtual float LenSquared() const override
float LenSquared() const override
{
return m_data[1] * m_data[1] + m_data[0] * m_data[0] + m_data[2] * m_data[2];
} // vtable+0x40
@@ -289,7 +289,7 @@ public:
// Vector3 overrides
// FUNCTION: LEGO1 0x10002870
virtual void AddImpl(float* p_value) override
void AddImpl(float* p_value) override
{
m_data[0] += p_value[0];
m_data[1] += p_value[1];
@@ -298,7 +298,7 @@ public:
} // vtable+0x04
// FUNCTION: LEGO1 0x100028b0
virtual void AddImpl(float p_value) override
void AddImpl(float p_value) override
{
m_data[0] += p_value;
m_data[1] += p_value;
@@ -307,7 +307,7 @@ public:
} // vtable+0x00
// FUNCTION: LEGO1 0x100028f0
virtual void SubImpl(float* p_value) override
void SubImpl(float* p_value) override
{
m_data[0] -= p_value[0];
m_data[1] -= p_value[1];
@@ -316,7 +316,7 @@ public:
} // vtable+0x08
// FUNCTION: LEGO1 0x10002970
virtual void MulScalarImpl(float* p_value) override
void MulScalarImpl(float* p_value) override
{
m_data[0] *= *p_value;
m_data[1] *= *p_value;
@@ -325,7 +325,7 @@ public:
} // vtable+0x0c
// FUNCTION: LEGO1 0x10002930
virtual void MulVectorImpl(float* p_value) override
void MulVectorImpl(float* p_value) override
{
m_data[0] *= p_value[0];
m_data[1] *= p_value[1];
@@ -334,7 +334,7 @@ public:
} // vtable+0x10
// FUNCTION: LEGO1 0x100029b0
virtual void DivScalarImpl(float* p_value) override
void DivScalarImpl(float* p_value) override
{
m_data[0] /= *p_value;
m_data[1] /= *p_value;
@@ -343,25 +343,25 @@ public:
} // vtable+0x14
// FUNCTION: LEGO1 0x100029f0
virtual float DotImpl(float* p_a, float* p_b) const override
float DotImpl(float* p_a, float* p_b) const override
{
return p_a[0] * p_b[0] + p_a[2] * p_b[2] + (p_a[1] * p_b[1] + p_a[3] * p_b[3]);
} // vtable+0x18
// FUNCTION: LEGO1 0x10002a20
virtual void EqualsImpl(float* p_data) override { memcpy(m_data, p_data, sizeof(float) * 4); } // vtable+0x20
void EqualsImpl(float* p_data) override { memcpy(m_data, p_data, sizeof(float) * 4); } // vtable+0x20
// FUNCTION: LEGO1 0x10002b00
virtual void Clear() override { memset(m_data, 0, sizeof(float) * 4); } // vtable+0x2c
void Clear() override { memset(m_data, 0, sizeof(float) * 4); } // vtable+0x2c
// FUNCTION: LEGO1 0x10002b20
virtual float LenSquared() const override
float LenSquared() const override
{
return m_data[1] * m_data[1] + m_data[0] * m_data[0] + m_data[2] * m_data[2] + m_data[3] * m_data[3];
} // vtable+0x40
// FUNCTION: LEGO1 0x10002b40
virtual void EqualsScalar(float* p_value) override
void EqualsScalar(float* p_value) override
{
m_data[0] = *p_value;
m_data[1] = *p_value;