(Proposal) Introduction of naming convention checker (ncc) (#322)

* Add ncc tool

* Add symlink

* Fixes

* Try this

* Try this

* Try this

* Try this

* Add include path

* Update style

* Update style

* Add more rules

* Fix style

* Update styles

* Fix name parameter

* Fix MxParam p

* Fix m_unk0x pattern

* Allow 4 digits for relative hex

* Add missing offset

* Fix some parameters

* Fix some vtables

* Fix more vtables

* Update rules, fixes

* More fixes

* More fixes

* More fixes

* More fixes

* More fixes

* More fixes

* More fixes

* Fix last issue

* Update readme

* Update readme

* Update CONTRIBUTING.md

* Fix annotations

* Rename

* Update CONTRIBUTING.md

* Update README.md
This commit is contained in:
Christian Semmler
2023-12-13 05:48:14 -05:00
committed by GitHub
parent 3b155bfe38
commit bc5ca621a4
303 changed files with 2592 additions and 1844 deletions

View File

@@ -38,7 +38,7 @@ ColorStringStruct g_colorSaveData[43] = {
// NOTE: This offset = the end of the variables table, the last entry
// in that table is a special entry, the string "END_OF_VARIABLES"
// GLOBAL: LEGO1 0x100f3e50
extern const char* s_endOfVariables;
extern const char* g_endOfVariables;
// FUNCTION: LEGO1 0x10039550
LegoGameState::LegoGameState()
@@ -94,9 +94,9 @@ MxResult LegoGameState::Save(MxULong p_slot)
if (fileStream.Open(savePath.GetData(), LegoStream::WriteBit) != FAILURE) {
MxU32 maybeVersion = 0x1000C;
fileStream.Write(&maybeVersion, 4);
fileStream.Write(&m_unk24, 2);
fileStream.Write(&m_unk10, 2);
fileStream.Write(&m_unkC, 1);
fileStream.Write(&m_unk0x24, 2);
fileStream.Write(&m_unk0x10, 2);
fileStream.Write(&m_unk0xc, 1);
for (MxS32 i = 0; i < sizeof(g_colorSaveData) / sizeof(g_colorSaveData[0]); ++i) {
if (LegoStream::WriteVariable(&fileStream, variableTable, g_colorSaveData[i].m_targetName) == FAILURE)
@@ -140,9 +140,9 @@ void LegoGameState::SetSavePath(char* p_savePath)
// FUNCTION: LEGO1 0x1003a020
MxResult LegoGameState::WriteEndOfVariables(LegoStream* p_stream)
{
MxU8 len = strlen(s_endOfVariables);
MxU8 len = strlen(g_endOfVariables);
if (p_stream->Write(&len, 1) == SUCCESS)
return p_stream->Write(s_endOfVariables, len);
return p_stream->Write(g_endOfVariables, len);
return FAILURE;
}
@@ -167,19 +167,19 @@ void LegoGameState::GetFileSavePath(MxString* p_outPath, MxULong p_slotn)
}
// STUB: LEGO1 0x1003a2e0
void LegoGameState::SerializePlayersInfo(MxS16 p)
void LegoGameState::SerializePlayersInfo(MxS16)
{
// TODO
}
// STUB: LEGO1 0x1003a720
void LegoGameState::FUN_1003a720(MxU32 p_unk)
void LegoGameState::FUN_1003a720(MxU32)
{
// TODO
}
// STUB: LEGO1 0x1003b060
void LegoGameState::HandleAction(MxU32 p_unk)
void LegoGameState::HandleAction(MxU32)
{
// TODO
}
@@ -256,7 +256,7 @@ void LegoGameState::RegisterState(LegoState* p_state)
}
// STUB: LEGO1 0x1003cdd0
void LegoGameState::SerializeScoreHistory(MxS16 p)
void LegoGameState::SerializeScoreHistory(MxS16)
{
// TODO
}
@@ -264,5 +264,5 @@ void LegoGameState::SerializeScoreHistory(MxS16 p)
// FUNCTION: LEGO1 0x1003cea0
void LegoGameState::SetSomeEnumState(undefined4 p_state)
{
m_unk10 = p_state;
m_unk0x10 = p_state;
}