mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 00:14:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add clang-tidy readability-redundant-inline-specifier (#1060)

Browse Source 
* Add clang-tidy readability-redundant-inline-specifier

* fix

* Update CONTRIBUTING.md

* format

* fix
This commit is contained in:
Christian Semmler
2024-07-04 16:06:32 -07:00
committed by GitHub
parent 0873b782c5
commit bee101b1f4
186 changed files with 872 additions and 886 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
LEGO1/lego/sources/anim/legoanim.h
View File

@@ -103,7 +103,7 @@ public:
LegoUnknownKey();
LegoResult Read(LegoStorage* p_storage);
inline LegoFloat GetZ() { return m_z; }
LegoFloat GetZ() { return m_z; }
protected:
LegoFloat m_z; // 0x08
@@ -216,13 +216,13 @@ public:
LegoResult Read(LegoStorage* p_storage);
LegoResult FUN_1009f490(LegoFloat p_time, Matrix4& p_matrix);
inline LegoU32 GetUnknown0x18() { return m_unk0x18; }
inline LegoU32 GetUnknown0x1c() { return m_unk0x1c; }
inline LegoU32 GetUnknown0x20() { return m_unk0x20; }
LegoU32 GetUnknown0x18() { return m_unk0x18; }
LegoU32 GetUnknown0x1c() { return m_unk0x1c; }
LegoU32 GetUnknown0x20() { return m_unk0x20; }
inline void SetUnknown0x18(LegoU32 p_unk0x18) { m_unk0x18 = p_unk0x18; }
inline void SetUnknown0x1c(LegoU32 p_unk0x1c) { m_unk0x1c = p_unk0x1c; }
inline void SetUnknown0x20(LegoU32 p_unk0x20) { m_unk0x20 = p_unk0x20; }
void SetUnknown0x18(LegoU32 p_unk0x18) { m_unk0x18 = p_unk0x18; }
void SetUnknown0x1c(LegoU32 p_unk0x1c) { m_unk0x1c = p_unk0x1c; }
void SetUnknown0x20(LegoU32 p_unk0x20) { m_unk0x20 = p_unk0x20; }
private:
LegoU16 m_unk0x00; // 0x00
@@ -250,7 +250,7 @@ public:
const LegoChar* GetActorName(LegoU32 p_index);
undefined4 GetActorUnknown0x04(LegoU32 p_index);
inline LegoAnimScene* GetScene() { return m_scene; }
LegoAnimScene* GetScene() { return m_scene; }
// SYNTHETIC: LEGO1 0x100a0ba0
// LegoAnim::`scalar deleting destructor'

8
LEGO1/lego/sources/geom/legoweedge.h
View File

@@ -15,11 +15,11 @@ public:
virtual LegoResult VTable0x04(); // vtable+0x04
inline LegoU8 GetNumEdges() { return m_numEdges; }
inline LegoEdge** GetEdges() { return m_edges; }
inline LegoU32 IsEqual(LegoWEEdge& p_other) { return this == &p_other; }
LegoU8 GetNumEdges() { return m_numEdges; }
LegoEdge** GetEdges() { return m_edges; }
LegoU32 IsEqual(LegoWEEdge& p_other) { return this == &p_other; }
inline void SetEdges(LegoEdge** p_edges, LegoU8 p_numEdges)
void SetEdges(LegoEdge** p_edges, LegoU8 p_numEdges)
{
m_edges = p_edges;
m_numEdges = p_numEdges;

12
LEGO1/lego/sources/geom/legowegedge.h
View File

@@ -40,12 +40,12 @@ public:
LegoResult VTable0x04() override; // vtable+0x04
inline LegoU32 GetFlag0x10() { return m_flags & c_bit5 ? FALSE : TRUE; }
inline Mx4DPointFloat* GetUnknown0x14() { return &m_unk0x14; }
inline Mx4DPointFloat* GetEdgeNormal(int index) { return &m_edgeNormals[index]; }
inline LegoChar* GetName() { return m_name; }
LegoU32 GetFlag0x10() { return m_flags & c_bit5 ? FALSE : TRUE; }
Mx4DPointFloat* GetUnknown0x14() { return &m_unk0x14; }
Mx4DPointFloat* GetEdgeNormal(int index) { return &m_edgeNormals[index]; }
LegoChar* GetName() { return m_name; }
inline void SetFlag0x10(LegoU32 p_disable)
void SetFlag0x10(LegoU32 p_disable)
{
if (p_disable) {
m_flags &= ~c_bit5;
@@ -55,7 +55,7 @@ public:
}
}
inline LegoU8 GetMask0x03() { return m_flags & (c_bit1 | c_bit2); }
LegoU8 GetMask0x03() { return m_flags & (c_bit1 | c_bit2); }
// SYNTHETIC: LEGO1 0x1009a7e0
// LegoWEGEdge::`scalar deleting destructor'

6
LEGO1/lego/sources/misc/legocontainer.h
View File

@@ -58,7 +58,7 @@ public:
}
// FUNCTION: BETA10 0x1007bc00
inline T* Get(const char* p_name)
T* Get(const char* p_name)
{
T* value = NULL;
@@ -75,7 +75,7 @@ public:
return value;
}
inline void Add(const char* p_name, T* p_value)
void Add(const char* p_name, T* p_value)
{
#ifdef COMPAT_MODE
typename LegoContainerInfo<T>::iterator it = m_map.find(p_name);
@@ -99,7 +99,7 @@ public:
m_map[name] = p_value;
}
inline void SetOwnership(LegoBool p_ownership) { m_ownership = p_ownership; }
void SetOwnership(LegoBool p_ownership) { m_ownership = p_ownership; }
protected:
LegoBool m_ownership; // 0x04

12
LEGO1/lego/sources/roi/legoroi.h
View File

@@ -60,13 +60,13 @@ public:
);
static LegoBool FUN_100a9cf0(const LegoChar* p_param, unsigned char* paletteEntries, LegoU32 p_numEntries);
inline const LegoChar* GetName() const { return m_name; }
inline LegoEntity* GetEntity() { return m_entity; }
const LegoChar* GetName() const { return m_name; }
LegoEntity* GetEntity() { return m_entity; }
inline void SetEntity(LegoEntity* p_entity) { m_entity = p_entity; }
inline void SetComp(CompoundObject* p_comp) { comp = p_comp; }
inline void SetBoundingSphere(const BoundingSphere& p_sphere) { m_sphere = m_world_bounding_sphere = p_sphere; }
inline void SetUnknown0x80(const BoundingBox& p_unk0x80) { m_unk0x80 = p_unk0x80; }
void SetEntity(LegoEntity* p_entity) { m_entity = p_entity; }
void SetComp(CompoundObject* p_comp) { comp = p_comp; }
void SetBoundingSphere(const BoundingSphere& p_sphere) { m_sphere = m_world_bounding_sphere = p_sphere; }
void SetUnknown0x80(const BoundingBox& p_unk0x80) { m_unk0x80 = p_unk0x80; }
// SYNTHETIC: LEGO1 0x100a82b0
// LegoROI::`scalar deleting destructor'