Add clang-tidy readability-redundant-inline-specifier (#1060)

* Add clang-tidy readability-redundant-inline-specifier

* fix

* Update CONTRIBUTING.md

* format

* fix
This commit is contained in:
Christian Semmler
2024-07-04 16:06:32 -07:00
committed by GitHub
parent 0873b782c5
commit bee101b1f4
186 changed files with 872 additions and 886 deletions

View File

@@ -85,7 +85,7 @@ public:
// Pixel data may be stored with padding.
// https://learn.microsoft.com/en-us/windows/win32/medfound/image-stride
// FUNCTION: BETA10 0x1002c510
inline MxLong AlignToFourByte(MxLong p_value) const { return (p_value + 3) & -4; }
MxLong AlignToFourByte(MxLong p_value) const { return (p_value + 3) & -4; }
// DECOMP: This could be a free function. It is static here because it has no
// reference to "this". In the beta it is called in two places:
@@ -95,27 +95,27 @@ public:
static MxLong HeightAbs(MxLong p_value) { return p_value > 0 ? p_value : -p_value; }
// FUNCTION: BETA10 0x10142030
inline BITMAPINFOHEADER* GetBmiHeader() const { return m_bmiHeader; }
BITMAPINFOHEADER* GetBmiHeader() const { return m_bmiHeader; }
// FUNCTION: BETA10 0x1002c440
inline MxLong GetBmiWidth() const { return m_bmiHeader->biWidth; }
inline MxLong GetBmiStride() const { return ((m_bmiHeader->biWidth + 3) & -4); }
inline MxLong GetBmiHeight() const { return m_bmiHeader->biHeight; }
MxLong GetBmiWidth() const { return m_bmiHeader->biWidth; }
MxLong GetBmiStride() const { return ((m_bmiHeader->biWidth + 3) & -4); }
MxLong GetBmiHeight() const { return m_bmiHeader->biHeight; }
// FUNCTION: BETA10 0x1002c470
inline MxLong GetBmiHeightAbs() const { return HeightAbs(m_bmiHeader->biHeight); }
MxLong GetBmiHeightAbs() const { return HeightAbs(m_bmiHeader->biHeight); }
// FUNCTION: BETA10 0x10083900
inline MxU8* GetImage() const { return m_data; }
MxU8* GetImage() const { return m_data; }
// FUNCTION: BETA10 0x100838d0
inline MxBITMAPINFO* GetBitmapInfo() const { return m_info; }
MxBITMAPINFO* GetBitmapInfo() const { return m_info; }
// FUNCTION: BETA10 0x100982b0
inline MxLong GetDataSize() const { return AlignToFourByte(m_bmiHeader->biWidth) * GetBmiHeightAbs(); }
MxLong GetDataSize() const { return AlignToFourByte(m_bmiHeader->biWidth) * GetBmiHeightAbs(); }
// FUNCTION: BETA10 0x1002c4b0
inline MxBool IsTopDown()
MxBool IsTopDown()
{
if (m_bmiHeader->biCompression == BI_RGB_TOPDOWN) {
return TRUE;
@@ -130,7 +130,7 @@ public:
: -p_bitmap->AlignToFourByte(p_bitmap->GetBmiWidth()))
// FUNCTION: BETA10 0x1002c320
inline MxU8* GetStart(MxS32 p_left, MxS32 p_top)
MxU8* GetStart(MxS32 p_left, MxS32 p_top)
{
if (m_bmiHeader->biCompression == BI_RGB) {
return m_data + p_left +
@@ -150,10 +150,10 @@ public:
private:
// FUNCTION: BETA10 0x1013dd10
inline MxLong MxBitmapInfoSize() const { return sizeof(MxBITMAPINFO); }
MxLong MxBitmapInfoSize() const { return sizeof(MxBITMAPINFO); }
// FUNCTION: BETA10 0x1013dd30
inline MxBool IsBottomUp()
MxBool IsBottomUp()
{
if (m_bmiHeader->biCompression == BI_RGB_TOPDOWN) {
return FALSE;