mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 00:14:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add clang-tidy readability-redundant-inline-specifier (#1060)

Browse Source 
* Add clang-tidy readability-redundant-inline-specifier

* fix

* Update CONTRIBUTING.md

* format

* fix
This commit is contained in:
Christian Semmler
2024-07-04 16:06:32 -07:00
committed by GitHub
parent 0873b782c5
commit bee101b1f4
186 changed files with 872 additions and 886 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
LEGO1/realtime/matrix.h
View File

@@ -17,7 +17,7 @@ struct UnknownMatrixType {
class Matrix4 {
public:
// FUNCTION: LEGO1 0x10004500
inline Matrix4(float (*p_data)[4]) { SetData(p_data); }
Matrix4(float (*p_data)[4]) { SetData(p_data); }
// Note: virtual function overloads appear in the virtual table
// in reverse order of appearance.
@@ -112,7 +112,7 @@ public:
inline virtual int FromQuaternion(const Vector4& p_vec); // vtable+0x44
// FUNCTION: LEGO1 0x100a0ff0
inline void Scale(const float& p_x, const float& p_y, const float& p_z)
void Scale(const float& p_x, const float& p_y, const float& p_z)
{
for (int i = 0; i < 4; i++) {
m_data[i][0] *= p_x;
@@ -121,7 +121,7 @@ public:
}
}
inline void RotateX(const float& p_angle)
void RotateX(const float& p_angle)
{
float s = sin(p_angle);
float c = cos(p_angle);
@@ -134,7 +134,7 @@ public:
}
// FUNCTION: BETA10 0x1001fd60
inline void RotateY(const float& p_angle)
void RotateY(const float& p_angle)
{
float s = sin(p_angle);
float c = cos(p_angle);
@@ -147,7 +147,7 @@ public:
}
// FUNCTION: BETA10 0x1006ab10
inline void RotateZ(const float& p_angle)
void RotateZ(const float& p_angle)
{
float s = sin(p_angle);
float c = cos(p_angle);
@@ -162,7 +162,7 @@ public:
inline int Unknown(Matrix4& p_mat);
// FUNCTION: LEGO1 0x1006b500
inline void Swap(int p_d1, int p_d2)
void Swap(int p_d1, int p_d2)
{
for (int i = 0; i < 4; i++) {
float e = m_data[p_d1][i];

2
LEGO1/realtime/realtimeview.h
View File

@@ -14,7 +14,7 @@ public:
static void UpdateMaxLOD();
static void SetUserMaxLOD(float);
inline static float GetUserMaxLodPower() { return g_userMaxLodPower; }
static float GetUserMaxLodPower() { return g_userMaxLodPower; }
};
#endif // REALTIMEVIEW_H

4
LEGO1/realtime/roi.h
View File

@@ -112,8 +112,8 @@ public:
int GetLODCount() const { return lods ? lods->Size() : 0; }
const CompoundObject* GetComp() const { return comp; }
inline unsigned char GetVisibility() { return m_visible; }
inline void SetVisibility(unsigned char p_visible) { m_visible = p_visible; }
unsigned char GetVisibility() { return m_visible; }
void SetVisibility(unsigned char p_visible) { m_visible = p_visible; }
// SYNTHETIC: LEGO1 0x100a5d60
// ROI::`scalar deleting destructor'

18
LEGO1/realtime/vector.h
View File

@@ -14,7 +14,7 @@
class Vector2 {
public:
// FUNCTION: LEGO1 0x1000c0f0
inline Vector2(float* p_data) { SetData(p_data); }
Vector2(float* p_data) { SetData(p_data); }
// Note: virtual function overloads appear in the virtual table
// in reverse order of appearance.
@@ -149,13 +149,13 @@ public:
// SYNTHETIC: LEGO1 0x10010be0
// Vector3::operator=
inline Vector2& operator=(const Vector2& p_other)
Vector2& operator=(const Vector2& p_other)
{
Vector2::SetVector(&p_other);
return *this;
}
inline float& operator[](int idx) { return m_data[idx]; }
inline const float& operator[](int idx) const { return m_data[idx]; }
float& operator[](int idx) { return m_data[idx]; }
const float& operator[](int idx) const { return m_data[idx]; }
protected:
float* m_data; // 0x04
@@ -166,20 +166,20 @@ protected:
class Vector3 : public Vector2 {
public:
// FUNCTION: LEGO1 0x1001d150
inline Vector3(float* p_data) : Vector2(p_data) {}
Vector3(float* p_data) : Vector2(p_data) {}
// Hack: Some code initializes a Vector3 from a (most likely) const float* source.
// Example: LegoCameraController::GetWorldUp
// Vector3 however is a class that can mutate its underlying source, making
// initialization with a const source fundamentally incompatible.
inline Vector3(const float* p_data) : Vector2((float*) p_data) {}
Vector3(const float* p_data) : Vector2((float*) p_data) {}
// Note: virtual function overloads appear in the virtual table
// in reverse order of appearance.
// FUNCTION: LEGO1 0x10002270
// FUNCTION: BETA10 0x100064a1
inline virtual void EqualsCrossImpl(float* p_a, float* p_b)
virtual void EqualsCrossImpl(float* p_a, float* p_b)
{
m_data[0] = p_a[1] * p_b[2] - p_a[2] * p_b[1];
m_data[1] = p_a[2] * p_b[0] - p_a[0] * p_b[2];
@@ -230,7 +230,7 @@ public:
} // vtable+0x08
// FUNCTION: LEGO1 0x10003b20
inline void MulScalarImpl(float* p_value) override
void MulScalarImpl(float* p_value) override
{
m_data[0] *= *p_value;
m_data[1] *= *p_value;
@@ -279,7 +279,7 @@ public:
// SIZE 0x08
class Vector4 : public Vector3 {
public:
inline Vector4(float* p_data) : Vector3(p_data) {}
Vector4(float* p_data) : Vector3(p_data) {}
// Note: virtual function overloads appear in the virtual table
// in reverse order of appearance.