Add clang-tidy readability-redundant-inline-specifier (#1060)

* Add clang-tidy readability-redundant-inline-specifier

* fix

* Update CONTRIBUTING.md

* format

* fix
This commit is contained in:
Christian Semmler
2024-07-04 16:06:32 -07:00
committed by GitHub
parent 0873b782c5
commit bee101b1f4
186 changed files with 872 additions and 886 deletions

View File

@@ -39,8 +39,8 @@ public:
inline static int Unknown2(float p_und1, float p_und2, ViewROI* p_roi);
inline static int Unknown3(ViewROI* p_roi);
inline const CompoundObject& GetROIs() { return rois; }
inline void Add(ViewROI* p_roi) { rois.push_back(p_roi); }
const CompoundObject& GetROIs() { return rois; }
void Add(ViewROI* p_roi) { rois.push_back(p_roi); }
// SYNTHETIC: LEGO1 0x100a6000
// ViewManager::`scalar deleting destructor'

View File

@@ -16,7 +16,7 @@
// SIZE 0xe4
class ViewROI : public OrientableROI {
public:
inline ViewROI(Tgl::Renderer* pRenderer, ViewLODList* lodList)
ViewROI(Tgl::Renderer* pRenderer, ViewLODList* lodList)
{
SetLODList(lodList);
geometry = pRenderer->CreateGroup();
@@ -24,14 +24,14 @@ public:
}
// FUNCTION: LEGO1 0x100a9e20
inline ~ViewROI() override
~ViewROI() override
{
// SetLODList() will decrease refCount of LODList
SetLODList(0);
delete geometry;
}
inline void SetLODList(ViewLODList* lodList)
void SetLODList(ViewLODList* lodList)
{
// ??? inherently type unsafe - kind of... because, now, ROI
// does not expose SetLODs() ...
@@ -56,8 +56,8 @@ public:
virtual Tgl::Group* GetGeometry(); // vtable+0x30
virtual const Tgl::Group* GetGeometry() const; // vtable+0x34
inline int GetUnknown0xe0() { return m_unk0xe0; }
inline void SetUnknown0xe0(int p_unk0xe0) { m_unk0xe0 = p_unk0xe0; }
int GetUnknown0xe0() { return m_unk0xe0; }
void SetUnknown0xe0(int p_unk0xe0) { m_unk0xe0 = p_unk0xe0; }
static undefined SetUnk101013d8(undefined p_flag);