mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 08:24:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make NotificationManager::Send take a const reference to notification (#836)

Browse Source 
* Make NotificationManager::Send take a const reference to notification

* Fix virtual func
This commit is contained in:
Christian Semmler
2024-04-22 08:11:38 -04:00
committed by GitHub
parent 0e0d6890ad
commit f1688be263
22 changed files with 50 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
LEGO1/omni/include/mxactionnotificationparam.h
View File

@@ -47,7 +47,7 @@ public:
}
// FUNCTION: LEGO1 0x100510c0
MxNotificationParam* Clone() override
MxNotificationParam* Clone() const override
{
return new MxActionNotificationParam(this->m_type, this->m_sender, this->m_action, this->m_realloc);
} // vtable+0x04
@@ -73,7 +73,7 @@ public:
{
}
MxNotificationParam* Clone() override; // vtable+0x04
MxNotificationParam* Clone() const override; // vtable+0x04
};
// VTABLE: LEGO1 0x100d8358
@@ -91,7 +91,7 @@ public:
}
// FUNCTION: LEGO1 0x10051270
MxNotificationParam* Clone() override
MxNotificationParam* Clone() const override
{
return new MxEndActionNotificationParam(
c_notificationEndAction,
@@ -112,7 +112,7 @@ public:
m_unk0x14 = p_unk0x14;
}
MxNotificationParam* Clone() override; // vtable+0x04
MxNotificationParam* Clone() const override; // vtable+0x04
private:
MxPresenter* m_unk0x14; // 0x14

4
LEGO1/omni/include/mxnotificationmanager.h
View File

@@ -9,7 +9,7 @@
class MxNotification {
public:
MxNotification(MxCore* p_target, MxNotificationParam* p_param);
MxNotification(MxCore* p_target, const MxNotificationParam& p_param);
~MxNotification();
inline MxCore* GetTarget() { return m_target; }
@@ -43,7 +43,7 @@ public:
virtual MxResult Create(MxU32 p_frequencyMS, MxBool p_createThread); // vtable+0x14
void Register(MxCore* p_listener);
void Unregister(MxCore* p_listener);
MxResult Send(MxCore* p_listener, MxNotificationParam* p_param);
MxResult Send(MxCore* p_listener, const MxNotificationParam& p_param);
inline MxNotificationPtrList* GetQueue() { return m_queue; }
inline void SetActive(MxBool p_active) { m_active = p_active; }

2
LEGO1/omni/include/mxnotificationparam.h
View File

@@ -42,7 +42,7 @@ public:
}
// FUNCTION: LEGO1 0x10010390
virtual MxNotificationParam* Clone() { return new MxNotificationParam(m_type, m_sender); } // vtable+0x04
virtual MxNotificationParam* Clone() const { return new MxNotificationParam(m_type, m_sender); } // vtable+0x04
inline NotificationId GetNotification() const { return m_type; }
inline MxCore* GetSender() const { return m_sender; }

2
LEGO1/omni/include/mxomni.h
View File

@@ -48,7 +48,7 @@ public:
virtual MxBool DoesEntityExist(MxDSAction& p_dsAction); // vtable+28
virtual MxResult CreatePresenter(MxStreamController* p_controller, MxDSAction& p_action); // vtable+2c
virtual MxEntity* AddToWorld(const char*, MxS32, MxPresenter*); // vtable+30
virtual void NotifyCurrentEntity(MxNotificationParam* p_param); // vtable+34
virtual void NotifyCurrentEntity(const MxNotificationParam& p_param); // vtable+34
virtual void StartTimer(); // vtable+38
virtual void StopTimer(); // vtable+3c

2
LEGO1/omni/include/mxstreamer.h
View File

@@ -24,7 +24,7 @@ public:
m_controller = p_ctrlr;
}
MxNotificationParam* Clone() override;
MxNotificationParam* Clone() const override;
MxStreamController* GetController() { return m_controller; }

2
LEGO1/omni/include/mxtype18notificationparam.h
View File

@@ -14,7 +14,7 @@ public:
}
// FUNCTION: LEGO1 0x1004afd0
MxNotificationParam* Clone() override
MxNotificationParam* Clone() const override
{
return new MxType18NotificationParam(m_type, m_sender, m_unk0x0c);
} // vtable+0x04