mirrors/isle
1
0
Fork 0
mirror of https://github.com/isledecomp/isle.git synced 2025-10-23 16:34:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

BETA10 import: Fix FUN_... collisions (#1105)

Browse Source 
* Improve BETA10 name import, refactor

* Run formatter

---------

Co-authored-by: jonschz <jonschz@users.noreply.github.com>
This commit is contained in:
jonschz
2024-09-14 16:16:12 +02:00
committed by GitHub
parent 7a6935a165
commit f89ee5c13d
3 changed files with 60 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tools/ghidra_scripts/lego_util/ghidra_helper.py
View File

@@ -8,6 +8,7 @@ from lego_util.exceptions import (
TypeNotFoundInGhidraError,
MultipleTypesFoundInGhidraError,
)
from lego_util.globals import GLOBALS, SupportedModules
# Disable spurious warnings in vscode / pylance
# pyright: reportMissingModuleSource=false
@@ -105,6 +106,12 @@ def sanitize_name(name: str) -> str:
.replace("`", "'")
)
# Importing function names like `FUN_10001234` into BETA10 can be confusing
# because Ghidra's auto-generated functions look exactly the same.
# Therefore, such function names are replaced by `LEGO_10001234` in the BETA10 import.
if GLOBALS.module == SupportedModules.BETA10:
new_name = re.sub(r"FUN_([0-9a-f]{8})", r"LEGO1_\1", new_name)
if "<" in name:
new_name = "_template_" + new_name