jonschz
73d9ef1d80
Improve FUN_10061010
, other fixes ( #1634 )
...
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2025-07-19 16:28:35 +02:00
jonschz
40c1a40d2b
Match FUN_1006b140()
and related functions ( #1623 )
...
* Match on BETA10
* Possible improvement on Matrix4::Swap
* Document entropy build result
* Comments at at Matrix4::Invert
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2025-07-13 16:50:51 +02:00
Fabian Neundorf
6497cb42b7
Clear unknowns in Matrix
( #1615 )
2025-07-10 18:58:53 -07:00
jonschz
f64af166c8
Add BETA10 addresses for LegoROI
and others ( #1569 )
...
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2025-06-21 07:52:24 +02:00
Fabian Neundorf
ac4d3b2490
Name for bounding box in ROI ( #1541 )
...
* Name for bounding box in ROI
* Use snake_case for member
2025-06-06 11:47:45 -07:00
Erik Schulze
eb1177b409
rename functions and parameters in OrientableROI ( #1512 )
2025-05-21 20:13:28 -07:00
Christian Semmler
ea5a722311
Fix Matrix4::operator[] annotation ( #1390 )
2025-02-22 06:48:11 -07:00
jonschz
956c900ec6
Match simple BETA10 vector calls ( #1382 )
...
* Add BETA10 for Vector2
* BETA10 match the remaining vector vtables
* Match vector implementations to BETA10
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2025-02-10 18:08:49 +01:00
Christian Semmler
fc03e7a682
Improve order until legomain.cpp
( #1350 )
...
* Fix `LegoBackgroundColor` order
* Order
* Improve order in Act3Actors
* Improve order
* Add BETA annotation
* Order more
* More order
* More order
* Order
* Match/order
* Remove blank line
* Modern compiler fix
* vtable annotation
2025-01-17 18:33:27 -07:00
Christian Semmler
646ee0d70a
Use COMPAT_MODE
to fix inline function not defined warnings on modern compilers ( #1315 )
...
* Use `COMPAT_MODE` to fix inline function not defined
* Fix
2025-01-09 01:15:29 +01:00
Christian Semmler
c54805fde8
Order functions in binary up to the end of Helicopter
; refactor vector/matrix classes ( #1309 )
...
* Order experimentation
* Revert IslePathActor
* Fix order
* Fix inlining
* Fixes
* WIP
* WIP
* Refactor
* Refactor
* Fix operators
* Remove obsolete inline keyword
* Fix ctors
* Refactor
* Rename files
* Refactor
* Remove empty line
2025-01-04 15:07:04 -07:00
Christian Semmler
669454a194
Use virtual operators in vector.h
( #1287 )
...
* Use virtual operators in vector.h
* Remove public
2024-12-27 18:20:18 +01:00
Christian Semmler
667ea3ff82
Various matches with BETA functions ( #1281 )
...
* Match functions to BETA
* Improve `Matrix4::FromQuaternion`
* Improve `Matrix4::ToQuaternion` match
* Fix bug that was fixed in retail
* Match `Vector4::NormalizeQuaternion`
2024-12-25 22:05:28 +01:00
jonschz
70baf8cecc
Fix float constants and conversions ( #1279 )
...
* Fix legoplants warnings, add BETA10 references
* Fix warnings in various header files, improve match
* Fix floats in legoactors.cpp
* Fix `legolocations.cpp`
* fix typo
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-12-25 21:01:00 +01:00
Christian Semmler
c2c9c75f1a
Fix Vector2
/Vector3
order ( #1272 )
...
* Fix Vector2/Vector3 order
* Refactor vector classes to be const and reference param consistent
* Add BETA10 annotations and fixes
2024-12-24 22:21:26 +01:00
Christian Semmler
7c41ff4569
Order compilation units according to retail, match and align Score
class ( #1271 )
...
* Initial changes for ordering, Score
* Add mxdebug
* Match `Score::Paint`
* Refactor
* Add BETA asserts
* BETA match
2024-12-24 19:38:15 +01:00
Christian Semmler
90c687bde0
Implement/match Act3Brickster::FUN_10042300
( #1238 )
...
* Implement/match `Act3Brickster::FUN_10042300`
* Add comment about assignment operator
* Add another comment
* Fix
* add back BETA annotation
2024-12-17 23:16:00 +01:00
Christian Semmler
1aeb458be1
Implement/match Act3Ammo::Animate
( #1221 )
...
* Implement/match `Act3Ammo::Animate`
* Match
* Rename
* Rename
* Rename
2024-12-13 22:56:26 +01:00
Christian Semmler
94ce89cbaa
(Proposal) Introduce arithmetic operators to Vector2 ( #1193 )
2024-12-07 17:26:22 +01:00
Christian Semmler
4d8098a6c2
Implement LegoPathController::FUN_10048310
( #1192 )
...
* WIP
* Rename
* Fix
* More WIP
* WIP
* WIP
* Fix
* Annotations
* Add more annotations, improve match
* Raise max functions
2024-12-06 20:50:40 +01:00
jonschz
5be9b343c4
Implement LegoJetskiRaceActor::VTable0x6c
, add BETA10 annotations ( #1160 )
...
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-11-19 16:20:27 +01:00
jonschz
4c0aae720b
Implement LegoCarBuild::FUN_10024890()
and others, refactor ( #1126 )
...
* Commit finished code changes
* Add enum data type
* Refactor away GetCurrentArea, SetCurrentArea
* Clean up and add FUN_10024890
* Add `SetPartObjectIdByName()`
* Fix naming error
* Address review comments, part 1
* Address review comments, part 2
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-11-01 09:21:15 -07:00
jonschz
b5fee6b240
Complete LegoCarBuildAnimPresenter
( #1114 )
...
* Complete `LegoCarBuildAnimPresenter`
* fix CI errors
* Drive-by BETA10 fixes
* Address review comments
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-10-20 14:00:44 -07:00
jonschz
85ce10ab50
Refactor various operator[]
based on BETA10 ( #1110 )
...
* Tidy up `operator[]` code
* Add weird index operator for `FUN_1002ddc0`
* Cleanup
* Add Matrix4 BETA10 annotations, fix typo
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-10-06 07:50:34 -07:00
jonschz
1a15981324
Implement LegoCarBuildAnimPresenter::StreamingTickle()
( #1109 )
...
* Implement LegoCarBuildAnimPresenter::StreamingTickle and dependents
* Fix naming issue
* Address review comment
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-10-05 16:20:45 -07:00
jonschz
e6474b7fcd
Implement LegoCarBuildAnimPresenter::FUN_10079920()
( #1108 )
...
* Implement `FUN_10079920()`
* Fix formatting
* Address review comment
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-10-04 17:19:42 +02:00
jonschz
a942325b29
More functions in LegoCarBuild
( #1104 )
...
* Add BETA10 annotations
* Clean up
* Implement multiple functions
* fix minor annotation error
* Undo formatting
* Fix formatting
* Implement more functions
* Rename variables, address review comment
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-09-14 16:14:11 -07:00
jonschz
5d19b6afe3
Improve UnknownMx4DPointFloat::FUN_100040a0
( #1102 )
...
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-09-09 12:45:48 -07:00
jonschz
2b14d3d6a5
Implement parts of LegoCarBuild
and dependents ( #1092 )
...
* Implement parts of `LegoCarBuild` and dependents
* Fix BETA10 offset
* Fix constants
* Code style: Rename parameters
* Linter fixes v2
* Linter errors v3
* Add BETA10 variable names for presenters
* Address review comments
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-09-03 13:50:30 -07:00
jonschz
b898d98515
BETA10: reccomp support and Ghidra imports ( #1091 )
...
* Implement core functionality (before linter)
* run linter + formatter
* Review: remove redundant code
* Implement end of range check for vtables
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-08-29 11:54:23 -07:00
jonschz
34047c0cb6
Implement/match LegoCarRaceActor::VTable0x6c
( #1085 )
...
* Implement/match `LegoCarRaceActor::VTable0x6c`
* Rename variable
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-08-17 08:59:22 -07:00
jonschz
a6a241b09d
Implement LegoCarRaceActor::VTable0x70
and VTable0x1c
( #1079 )
...
* Implement/match `LegoCarRaceActor::VTable0x70`
* Add BETA10 annotations
* Start with VTable0x9c, fix data type
* basic BETA10 code completion
* small fix
* small fix
* cleanup
* Fix formatting
* Address review comments
* review comment
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-08-08 12:55:01 -07:00
jonschz
e09acfcddb
Implement/match LegoCarRaceActor::VTable0x1c
( #1078 )
...
* Implement/match `LegoCarRaceActor::VTable0x1c`
* Fix formatting
* Fix LegoEdge::CWVertex()
* Fix more CI issues
* Trz to fix lvalue compile issue
* Fix formatting
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-08-04 21:13:12 +02:00
jonschz
4a41671759
Implement/match LegoRaceActor
( #1072 )
...
* Implement LegoRaceActor, add annotations
* Change code duplication comments
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-08-02 22:29:21 -07:00
jonschz
1f251ff817
Implement/match LegoCarRaceActor::FUN_10080590
( #1070 )
...
* Implement/match `LegoCarRaceActor::FUN_10080590`
* Add vbtable annotations
* disable formatter for assertion
* Fix BETA10 annotations
* Address review comments
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-07-28 20:13:18 +02:00
jonschz
0d385e27d0
Implement/match LegoRaceCar::VTable0x94
( #1068 )
...
* Implement LegoRaceCar::VTable0x94
* Remove redundant inline modifiers
* Fix offsets
* Fix minor inconsistency
* Address review comments
* Address review comments, round 2
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-07-26 10:53:09 -07:00
jonschz
afa5b90117
Implement LegoRaceCar::FUN_10012ff0()
, refactoring ( #1063 )
...
* Implement `LegoRaceCar::FUN_10012ff0()`, refactor based on BETA10
* Add BETA10 annotations
* Rename functions and variables based on BETA10 assertions
* Address issues raised by linter
* Rename variable, add BETA10 vtables
* Rename legoracecar files to legoracers
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-07-07 05:10:46 -07:00
Christian Semmler
bee101b1f4
Add clang-tidy readability-redundant-inline-specifier ( #1060 )
...
* Add clang-tidy readability-redundant-inline-specifier
* fix
* Update CONTRIBUTING.md
* format
* fix
2024-07-05 01:06:32 +02:00
jonschz
fb34f86171
Improve several functions in vector.h
( #1049 )
...
* Improve some functions in vector.h
- Add BETA10 references
- inline some functions based on BETA10
- Identify and improve `Vector4::EqualsHamiltonProduct`
* Fix BETA10 offset
* Fix BETA10 annotation order
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-06-30 13:45:10 -07:00
Christian Semmler
dd1c11a933
Fix camera glitch ( #1031 )
2024-06-13 22:09:14 +02:00
Christian Semmler
9a9bccda0e
Implement/match IslePathActor::Exit ( #997 )
...
* Implement/match IslePathActor::Exit
* Name
* Name
* Partially fix vector interface
* Revert "Partially fix vector interface"
This reverts commit 6e7a1e2b08
.
* Revert "Revert "Partially fix vector interface""
This reverts commit e3860e3c9f
.
* Fix
* Remove some COMPAT_MODE
2024-06-06 17:45:37 +02:00
Christian Semmler
689178f689
Implement/match LegoCameraController::FUN_10012290 and FUN_10012320 ( #969 )
2024-05-30 14:48:14 +02:00
Christian Semmler
da48dfb40d
Implement/match LegoAnimPresenter::FUN_1006b140 ( #963 )
2024-05-28 15:23:23 -04:00
Christian Semmler
8428cde67f
Implement LegoUnknown::FUN_1009a1e0 ( #940 )
2024-05-19 16:36:11 -04:00
Cameron
d106aada11
basic name improvements ( #930 )
...
* basic name improvements
* clang-format
---------
Co-authored-by: Christian Semmler <mail@csemmler.com >
2024-05-18 15:20:05 -04:00
Christian Semmler
dcaa07cc49
Implement/match LegoPathController::Create and Init ( #911 )
2024-05-12 20:33:20 +02:00
MS
79791be574
Beta addrs for ViewLODList ( #898 )
...
* Beta addrs for ViewLODList
* unsigned char
2024-05-09 22:16:12 -04:00
Christian Semmler
556cbdaab3
Implement/match LegoAnimationManager::FUN_10062650 ( #896 )
...
* Implement/match LegoAnimationManager::FUN_10062650
* Shorten code
2024-05-09 22:24:45 +02:00
jonschz
6382347f73
Refactor Matrix4::ToQuaternion() ( #879 )
...
* Refactor Matrix4::ToQuaternion()
* fix CI errors
* Apply feedback by @foxtacles
* run formatter
---------
Co-authored-by: jonschz <jonschz@users.noreply.github.com >
2024-05-03 14:08:58 -04:00
MS
446caa4ca1
Beta matching MxDSObject/MxDSAction ( #878 )
...
* Beta matching MxDSObject/MxDSAction
* MxDSAction copy constructor
* A bit more refactor
---------
Co-authored-by: Christian Semmler <mail@csemmler.com >
2024-05-03 14:01:27 +02:00