seppdroid/AdvancedSessionsPlugin
1
0
Fork 0
mirror of https://github.com/mordentral/AdvancedSessionsPlugin.git synced 2025-10-23 00:14:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed a missing validity check in GetFriendsCallbackProxy

Browse Source 
If a player controller was removed between when the node was called and when it resolved it would crash.

Other async nodes were checked and they were not missing a validation check.


Former-commit-id: 971738d49efeb611978366be370060cae5d10dba
This commit is contained in:
mordentral
2017-03-23 15:51:51 -04:00
parent af9bed57e7
commit edaec9f64c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
AdvancedSessions/Source/AdvancedSessions/Private/GetFriendsCallbackProxy.cpp
View File

@@ -53,7 +53,8 @@ void UGetFriendsCallbackProxy::OnReadFriendsListCompleted(int32 LocalUserNum, bo
IOnlineFriendsPtr Friends = Online::GetFriendsInterface(); IOnlineFriendsPtr Friends = Online::GetFriendsInterface();
if (Friends.IsValid()) if (Friends.IsValid())
{ {
ULocalPlayer* Player = Cast<ULocalPlayer>(PlayerControllerWeakPtr->Player); // Not actually needed anymore, plus was not being validated and causing a crash
//ULocalPlayer* Player = Cast<ULocalPlayer>(PlayerControllerWeakPtr->Player);
TArray<FBPFriendInfo> FriendsListOut; TArray<FBPFriendInfo> FriendsListOut;
TArray< TSharedRef<FOnlineFriend> > FriendList; TArray< TSharedRef<FOnlineFriend> > FriendList;