mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixes

Browse Source
This commit is contained in:
snwy
2024-11-07 17:23:26 -08:00
parent bb07e4a18c
commit 0ca1ee5c2a
2 changed files with 4 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/js/internal/streams/from.js
View File

@@ -98,7 +98,7 @@ function from(Readable, iterable, opts) {
if (value === null) {
reading = false;
throw $ERR_STREAM_NULL_VALUES();
throw $ERR_STREAM_NULL_VALUES("Null value");
}
if (readable.push(value)) {
@@ -121,7 +121,7 @@ function from(Readable, iterable, opts) {
if (res === null) {
reading = false;
throw $ERR_STREAM_NULL_VALUES();
throw $ERR_STREAM_NULL_VALUES("Null value ");
}
if (readable.push(res)) {
@@ -149,7 +149,7 @@ function from(Readable, iterable, opts) {
if (res === null) {
reading = false;
throw $ERR_STREAM_NULL_VALUES();
throw $ERR_STREAM_NULL_VALUES("Null value");
}
if (readable.push(res)) {
@@ -176,7 +176,7 @@ function from(Readable, iterable, opts) {
if (value === null) {
reading = false;
throw $ERR_STREAM_NULL_VALUES();
throw $ERR_STREAM_NULL_VALUES("Null value");
}
if (readable.push(value)) {

93
test/js/node/test/parallel/stream-duplex-readable-writable.test.js
View File

@@ -1,93 +0,0 @@
//#FILE: test-stream-duplex-readable-writable.js
//#SHA1: d56d29f5fbb8adc3d61708839985f0ea7ffb9b5c
//-----------------
"use strict";
const { Duplex } = require("stream");
test("Duplex with readable false", () => {
const duplex = new Duplex({
readable: false,
});
expect(duplex.readable).toBe(false);
duplex.push("asd");
const errorHandler = jest.fn();
duplex.on("error", errorHandler);
const dataHandler = jest.fn();
duplex.on("data", dataHandler);
const endHandler = jest.fn();
duplex.on("end", endHandler);
return new Promise(resolve => {
expect(errorHandler).toHaveBeenCalledTimes(1);
expect(errorHandler).toHaveBeenCalledWith(
expect.objectContaining({
code: "ERR_STREAM_PUSH_AFTER_EOF",
message: expect.any(String),
}),
);
expect(dataHandler).not.toHaveBeenCalled();
expect(endHandler).not.toHaveBeenCalled();
resolve();
});
});
test("Duplex with writable false", () => {
const writeSpy = jest.fn();
const duplex = new Duplex({
writable: false,
write: writeSpy,
});
expect(duplex.writable).toBe(false);
duplex.write("asd");
const errorHandler = jest.fn();
duplex.on("error", errorHandler);
const finishHandler = jest.fn();
duplex.on("finish", finishHandler);
return new Promise(resolve => {
setImmediate(() => {
expect(errorHandler).toHaveBeenCalledTimes(1);
expect(errorHandler).toHaveBeenCalledWith(
expect.objectContaining({
code: "ERR_STREAM_WRITE_AFTER_END",
message: expect.any(String),
}),
);
expect(writeSpy).not.toHaveBeenCalled();
expect(finishHandler).not.toHaveBeenCalled();
resolve();
});
});
});
test("Duplex with readable false and async iteration", async () => {
const duplex = new Duplex({
readable: false,
});
expect(duplex.readable).toBe(false);
const dataHandler = jest.fn();
duplex.on("data", dataHandler);
const endHandler = jest.fn();
duplex.on("end", endHandler);
async function run() {
for await (const chunk of duplex) {
expect(chunk).toBeFalsy(); // This should never be reached
}
}
await run();
expect(dataHandler).not.toHaveBeenCalled();
expect(endHandler).not.toHaveBeenCalled();
});
//<#END_FILE: test-stream-duplex-readable-writable.js