mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-15 05:12:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix race condition in child_process

Browse Source
This commit is contained in:
Jarred Sumner
2022-12-04 08:32:51 -08:00
parent f4668e45f8
commit 10cd5aaa15
1 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/bun.js/child_process.exports.js
View File

@@ -867,7 +867,6 @@ function checkExecSyncError(ret, args, cmd) {
//------------------------------------------------------------------------------
export class ChildProcess extends EventEmitter {
#handle;
#handleExited;
#exited = false;
#closesNeeded = 1;
#closesGot = 0;
@@ -1061,28 +1060,37 @@ export class ChildProcess extends EventEmitter {
const bunStdio = getBunStdioFromOptions(stdio);
var env = options.envPairs || undefined;
if (env === process.env) env = undefined;
this.#encoding = options.encoding || undefined;
this.#stdioOptions = bunStdio;
var hasEmittedSpawn = false;
this.#handle = Bun.spawn({
cmd: spawnargs,
stdin: bunStdio[0],
stdout: bunStdio[1],
stderr: bunStdio[2],
cwd: options.cwd || undefined,
env,
env: env || process.env,
onExit: (handle, exitCode, signalCode, err) => {
this.#handle = handle;
this.#handleOnExit(exitCode, signalCode, err);
this.pid = this.#handle.pid;
if (!hasEmittedSpawn) {
hasEmittedSpawn = true;
process.nextTick(onSpawnNT, this);
process.nextTick(this.#handleOnExit, exitCode, signalCode, err);
} else {
this.#handleOnExit(exitCode, signalCode, err);
}
},
lazy: true,
});
this.#handleExited = this.#handle.exited;
this.#encoding = options.encoding || undefined;
this.#stdioOptions = bunStdio;
this.pid = this.#handle.pid;
process.nextTick(onSpawnNT, this);
if (!hasEmittedSpawn) {
process.nextTick(onSpawnNT, this);
hasEmittedSpawn = true;
}
// const ipc = stdio.ipc;
// const ipcFd = stdio.ipcFd;