mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-16 22:01:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix issues with NAPI tests (#13831)

Browse Source 
Co-authored-by: 190n <190n@users.noreply.github.com>
This commit is contained in:
190n
2024-09-09 16:08:40 -08:00
committed by GitHub
parent 2b50554596
commit 282b92d6e1
3 changed files with 52 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
test/napi/napi-app/binding.gyp
View File

@@ -1,18 +1,23 @@
{
"targets": [{
"target_name": "napitests",
"cflags!": [ "-fno-exceptions" ],
"cflags_cc!": [ "-fno-exceptions" ],
"sources": [
"main.cpp"
],
'include_dirs': [
"<!@(node -p \"require('node-addon-api').include\")"
],
'libraries': [],
'dependencies': [
"<!(node -p \"require('node-addon-api').gyp\")"
],
'defines': [ 'NAPI_DISABLE_CPP_EXCEPTIONS', 'NODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUT=1' ],
}]
}
"targets": [
{
"target_name": "napitests",
"cflags!": ["-fno-exceptions"],
"cflags_cc!": ["-fno-exceptions"],
"msvs_settings": {
"VCCLCompilerTool": {
"ExceptionHandling": "0",
"AdditionalOptions": ["/std:c++20"],
},
},
"sources": ["main.cpp"],
"include_dirs": ["<!@(node -p \"require('node-addon-api').include\")"],
"libraries": [],
"dependencies": ["<!(node -p \"require('node-addon-api').gyp\")"],
"defines": [
"NAPI_DISABLE_CPP_EXCEPTIONS",
"NODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUT=1",
],
}
]
}

28
test/napi/napi-app/main.cpp
View File

@@ -1,12 +1,13 @@
#include <node.h>
#include <inttypes.h>
#include <iostream>
#include <napi.h>
#include <stdarg.h>
#include <stdio.h>
#include <array>
#include <cassert>
#include <cstdarg>
#include <cstdint>
#include <cstdio>
#include <iostream>
napi_value fail(napi_env env, const char *msg) {
napi_value result;
@@ -431,6 +432,24 @@ napi_value create_promise(const Napi::CallbackInfo &info) {
return promise;
}
napi_value test_napi_ref(const Napi::CallbackInfo &info) {
napi_env env = info.Env();
napi_value object;
assert(napi_create_object(env, &object) == napi_ok);
napi_ref ref;
assert(napi_create_reference(env, object, 0, &ref) == napi_ok);
napi_value from_ref;
assert(napi_get_reference_value(env, ref, &from_ref) == napi_ok);
assert(from_ref != nullptr);
napi_valuetype typeof_result;
assert(napi_typeof(env, from_ref, &typeof_result) == napi_ok);
assert(typeof_result == napi_object);
return ok(env);
}
Napi::Value RunCallback(const Napi::CallbackInfo &info) {
Napi::Env env = info.Env();
Napi::Function cb = info[0].As<Napi::Function>();
@@ -472,6 +491,7 @@ Napi::Object InitAll(Napi::Env env, Napi::Object exports1) {
exports.Set("get_class_with_constructor",
Napi::Function::New(env, get_class_with_constructor));
exports.Set("create_promise", Napi::Function::New(env, create_promise));
exports.Set("test_napi_ref", Napi::Function::New(env, test_napi_ref));
return exports;
}

6
test/napi/napi.test.ts
View File

@@ -116,6 +116,12 @@ describe("napi", () => {
);
});
});
describe("napi_ref", () => {
it("can recover the value from a weak ref", () => {
checkSameOutput("test_napi_ref", []);
});
});
});
function checkSameOutput(test: string, args: any[] | string) {