mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: memory leak when reading chunks from a stream

Browse Source
This commit is contained in:
Don Isaac
2024-12-30 23:17:07 -05:00
parent e96dded366
commit 327451429d
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/bun.js/webcore/streams.zig
View File

@@ -709,6 +709,8 @@ pub const StreamResult = union(Tag) {
switch (this.*) {
.owned => |*owned| owned.deinitWithAllocator(bun.default_allocator),
.owned_and_done => |*owned_and_done| owned_and_done.deinitWithAllocator(bun.default_allocator),
.temporary => |*temporary| temporary.deinitWithAllocator(bun.default_allocator),
.temporary_and_done => |*temporary_and_done| temporary_and_done.deinitWithAllocator(bun.default_allocator),
.err => |err| {
if (err == .JSValue) {
err.JSValue.unprotect();
@@ -1021,6 +1023,12 @@ pub const StreamResult = union(Tag) {
const value = result.toJS(globalThis);
value.ensureStillAlive();
switch (result.*) {
.temporary, .temporary_and_done => {
result.deinit();
},
else => {},
}
result.* = .{ .temporary = .{} };
promise.resolve(globalThis, value);
},