mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-12 03:48:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(repl): use globalObject instead of globalThis for _ and _error variables

Browse Source 
The globalThis() method returns a JSGlobalProxy which doesn't expose
properties set via putDirect to the global scope. By putting directly
on globalObject instead, the _ and _error special REPL variables are
now visible when referenced in subsequent expressions.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Claude Bot
2026-01-20 19:08:00 +00:00
parent 974fb9a272
commit 32e2540e56
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/bun.js/bindings/bindings.cpp
View File

@@ -6141,23 +6141,24 @@ extern "C" JSC::EncodedJSValue Bun__REPL__evaluate(
if (evalException) {
*exception = JSC::JSValue::encode(evalException->value());
// Set _error to the exception
globalObject->globalThis()->putDirect(vm, JSC::Identifier::fromString(vm, "_error"_s), evalException->value());
// Set _error on the globalObject directly (not globalThis proxy)
globalObject->putDirect(vm, JSC::Identifier::fromString(vm, "_error"_s), evalException->value());
scope.clearException();
return JSC::JSValue::encode(JSC::jsUndefined());
}
if (scope.exception()) {
*exception = JSC::JSValue::encode(scope.exception()->value());
// Set _error to the exception
globalObject->globalThis()->putDirect(vm, JSC::Identifier::fromString(vm, "_error"_s), scope.exception()->value());
// Set _error on the globalObject directly (not globalThis proxy)
globalObject->putDirect(vm, JSC::Identifier::fromString(vm, "_error"_s), scope.exception()->value());
scope.clearException();
return JSC::JSValue::encode(JSC::jsUndefined());
}
// Set _ to the last result (only if it's not undefined)
// Put directly on globalObject, which is the target of the globalThis proxy
if (!result.isUndefined()) {
globalObject->globalThis()->putDirect(vm, JSC::Identifier::fromString(vm, "_"_s), result);
globalObject->putDirect(vm, JSC::Identifier::fromString(vm, "_"_s), result);
}
return JSC::JSValue::encode(result);