mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 18:38:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix umask handling in bin linking

Browse Source 
- Change `umask | 0o777` to `0o777 & ~umask` for correct permission calculation
- Make `ensureUmask` restore the original umask instead of leaving it at zero

Co-authored-by: Jarred-Sumner <Jarred-Sumner@users.noreply.github.com>
This commit is contained in:
claude[bot]
2025-05-31 02:35:12 +00:00
committed by GitHub
parent 127fcf2d27
commit 3cab11cb3f
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/install/bin.zig
View File

@@ -581,13 +581,16 @@ pub const Bin = extern struct {
err: ?anyerror = null,
pub var umask: bun.Mode = 0;
var original_umask: bun.Mode = 0;
var has_set_umask = false;
pub fn ensureUmask() void {
if (!has_set_umask) {
has_set_umask = true;
umask = bun.sys.umask(0);
original_umask = bun.sys.umask(0);
umask = original_umask;
_ = bun.sys.umask(original_umask);
}
}
@@ -765,7 +768,7 @@ pub const Bin = extern struct {
// An extra stat() is cheaper than a copy-up of potentially large executables in Docker.
switch (bun.sys.stat(abs_target)) {
.result => |*stat| {
const desired_mode = umask | 0o777;
const desired_mode = 0o777 & ~umask;
if ((stat.mode & 0o777) != desired_mode) {
_ = bun.sys.chmod(abs_target, desired_mode);
}