mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-13 20:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Micro optimizations for mysql client

Browse Source
This commit is contained in:
Jarred Sumner
2025-08-21 16:57:12 -07:00
parent ecbf103bf5
commit 3f74f553a1
2 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/bun.js/bindings/SQLClient.cpp
View File

@@ -147,7 +147,7 @@ static JSC::JSValue toJS(JSC::VM& vm, JSC::JSGlobalObject* globalObject, DataCel
}
case DataCellTag::String: {
if (cell.value.string) {
return jsString(vm, WTF::String(cell.value.string));
return jsString(vm, WTF::String(std::exchange(cell.value.string, nullptr)));
}
return jsEmptyString(vm);
}
@@ -379,22 +379,16 @@ static JSC::JSValue toJS(JSC::Structure* structure, DataCell* cells, uint32_t co
case BunResultMode::Raw: // raw is just array mode with raw values
case BunResultMode::Values: // values
{
auto* array = JSC::constructEmptyArray(globalObject, static_cast<ArrayAllocationProfile*>(nullptr), count);
RETURN_IF_EXCEPTION(scope, {});
MarkedArgumentBuffer args;
for (uint32_t i = 0; i < count; i++) {
auto& cell = cells[i];
JSValue value = toJS(vm, globalObject, cell);
RETURN_IF_EXCEPTION(scope, {});
array->putDirectIndex(globalObject, i, value);
args.append(value);
}
return array;
}
default:
// not a valid result mode
ASSERT_NOT_REACHED();
return jsUndefined();
return JSC::constructArray(globalObject, static_cast<ArrayAllocationProfile*>(nullptr), args);
}
}
}
static JSC::JSValue toJS(JSC::JSArray* array, JSC::Structure* structure, DataCell* cells, uint32_t count, JSC::JSGlobalObject* globalObject, Bun::BunStructureFlags flags, BunResultMode result_mode, ExternColumnIdentifier* namesPtr, uint32_t namesCount)

2
src/sql/mysql/protocol/ResultSet.zig
View File

@@ -129,7 +129,7 @@ pub const Row = struct {
fn decodeText(this: *Row, allocator: std.mem.Allocator, comptime Context: type, reader: NewReader(Context)) AnyMySQLError.Error!void {
const cells = try allocator.alloc(SQLDataCell, this.columns.len);
@memset(cells, SQLDataCell{ .tag = .null, .value = .{ .null = 0 } });
// @memset(cells, SQLDataCell{ .tag = .null, .value = .{ .null = 0 } });
errdefer {
for (cells) |*value| {
value.deinit();