mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-02 15:08:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable SIMD multiline comment optimization (#13844)

Browse Source 
Co-authored-by: Meghan Denny <meghan@bun.sh>
Co-authored-by: nektro <5464072+nektro@users.noreply.github.com>
This commit is contained in:
Jarred Sumner
2025-07-13 04:46:07 -07:00
committed by GitHub
parent 285f708fe6
commit 499eac0d49
1 changed files with 18 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/js_lexer.zig
View File

@@ -1533,21 +1533,20 @@ fn NewLexer_(
);
},
else => {
// if (comptime Environment.enableSIMD) {
// TODO: this seems to work, but we shouldn't enable this until after improving test coverage
// if (lexer.code_point < 128) {
// const remainder = lexer.source.contents[lexer.current..];
// if (remainder.len >= 4096) {
// lexer.current += skipToInterestingCharacterInMultilineComment(remainder) orelse {
// lexer.step();
// continue;
// };
// lexer.end = lexer.current -| 1;
// lexer.step();
// continue;
// }
// }
// }
if (comptime Environment.enableSIMD) {
if (lexer.code_point < 128) {
const remainder = lexer.source.contents[lexer.current..];
if (remainder.len >= 512) {
lexer.current += skipToInterestingCharacterInMultilineComment(remainder) orelse {
lexer.step();
continue;
};
lexer.end = lexer.current -| 1;
lexer.step();
continue;
}
}
}
lexer.step();
},
@@ -3353,8 +3352,8 @@ fn skipToInterestingCharacterInMultilineComment(text_: []const u8) ?u32 {
const V1x16 = strings.AsciiVectorU1;
const text_end_len = text.len & ~(@as(usize, strings.ascii_vector_size) - 1);
bun.assert(text_end_len % strings.ascii_vector_size == 0);
bun.assert(text_end_len <= text.len);
bun.assertWithLocation(text_end_len % strings.ascii_vector_size == 0, @src());
bun.assertWithLocation(text_end_len <= text.len, @src());
const text_end_ptr = text.ptr + text_end_len;
@@ -3370,8 +3369,8 @@ fn skipToInterestingCharacterInMultilineComment(text_: []const u8) ?u32 {
if (@reduce(.Max, any_significant) > 0) {
const bitmask = @as(u16, @bitCast(any_significant));
const first = @ctz(bitmask);
bun.assert(first < strings.ascii_vector_size);
bun.assert(text.ptr[first] == '*' or text.ptr[first] == '\r' or text.ptr[first] == '\n' or text.ptr[first] > 127);
bun.assertWithLocation(first < strings.ascii_vector_size, @src());
bun.assertWithLocation(text.ptr[first] == '*' or text.ptr[first] == '\r' or text.ptr[first] == '\n' or text.ptr[first] > 127, @src());
return @as(u32, @truncate(first + (@intFromPtr(text.ptr) - @intFromPtr(text_.ptr))));
}
text.ptr += strings.ascii_vector_size;