mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-13 04:18:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove immediate cpp task

Browse Source
This commit is contained in:
Alistair Smith
2025-06-02 16:44:02 -07:00
parent d23afd6c9b
commit 4e451f9521
3 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/bun.js/bindings/webcore/MessagePort.cpp
View File

@@ -185,7 +185,7 @@ ExceptionOr<void> MessagePort::postMessage(JSC::JSGlobalObject& state, JSC::JSVa
auto* context = scriptExecutionContext();
if (!context->canSendMessage()) {
context->postImmediateCppTask([protectedThis = Ref { *this }, message = WTFMove(message)](ScriptExecutionContext& ctx) mutable {
context->postTask([protectedThis = Ref { *this }, message = WTFMove(message)](ScriptExecutionContext& ctx) mutable {
if (protectedThis->isEntangled()) {
MessagePortChannelProvider::fromContext(ctx).postMessageToRemote(WTFMove(message), protectedThis->m_remoteIdentifier);
}
@@ -289,7 +289,7 @@ void MessagePort::processMessages(ScriptExecutionContext& context, Vector<Messag
if (!deferredMessages.isEmpty()) {
// remaining messages should happen on da next tick
context.postImmediateCppTask(
context.postTask(
[protectedThis = Ref { *this }, deferred = WTFMove(deferredMessages), completionCallback = WTFMove(completionCallback)](ScriptExecutionContext& ctx) mutable {
RefPtr<ScriptExecutionContext> contextPtr = protectedThis->scriptExecutionContext();
if (!contextPtr || contextPtr->activeDOMObjectsAreSuspended() || !protectedThis->isEntangled()) {

1
src/bun.js/event_loop.zig
View File

@@ -479,7 +479,6 @@ pub fn tick(this: *EventLoop) void {
while (true) {
while (this.tickWithCount(ctx) > 0) : (this.global.handleRejectedPromises()) {
this.tickConcurrent();
this.tickImmediateTasks(ctx);
} else {
this.drainMicrotasksWithGlobal(global, global_vm) catch return;
if (scope.hasException()) return;

10
test/js/web/workers/message-port-lifecycle.test.ts
View File

@@ -2,7 +2,7 @@ import assert from "node:assert";
import { test } from "node:test";
import { MessageChannel, receiveMessageOnPort, Worker } from "worker_threads";
test("MessagePort postMessage uses immediate C++ tasks correctly", async () => {
test("MessagePort postMessage respects event loop timing", async () => {
const { port1, port2 } = new MessageChannel();
const messages: string[] = [];
@@ -90,7 +90,7 @@ test("MessagePort messages execute after process.nextTick (Node.js compatibility
port2.close();
});
test("MessagePort immediate C++ tasks work with workers", async () => {
test("MessagePort message delivery works with workers", async () => {
const worker = new Worker(
`
const { parentPort, MessageChannel } = require('worker_threads');
@@ -169,7 +169,7 @@ test("MessagePort immediate C++ tasks work with workers", async () => {
worker.terminate();
});
test("immediate C++ tasks don't starve microtasks", async () => {
test("MessagePort messages don't starve microtasks", async () => {
const { port1, port2 } = new MessageChannel();
const executionOrder: string[] = [];
@@ -252,7 +252,7 @@ test("high volume MessagePort operations maintain order", async () => {
port2.close();
});
test("MessagePort close behavior with immediate C++ tasks", async () => {
test("MessagePort close behavior during message handling", async () => {
const { port1, port2 } = new MessageChannel();
let messageReceived = false;
@@ -286,7 +286,7 @@ test("MessagePort close behavior with immediate C++ tasks", async () => {
port1.close();
});
test("receiveMessageOnPort works with immediate C++ tasks", () => {
test("receiveMessageOnPort synchronous message retrieval", () => {
const { port1, port2 } = new MessageChannel();
port1.postMessage("msg1");