mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing v

Browse Source 
Fixes https://github.com/oven-sh/bun/issues/1554
This commit is contained in:
Jarred Sumner
2022-11-27 22:41:16 -08:00
parent 4ee11d922c
commit 512acf072e
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/bun.js/bindings/Process.cpp
View File

@@ -348,7 +348,7 @@ void Process::finishCreation(JSC::VM& vm)
JSC::JSValue(JSC::jsNumber(0)));
this->putDirect(this->vm(), clientData->builtinNames().versionPublicName(),
JSC::jsString(this->vm(), makeAtomString(REPORTED_NODE_VERSION)));
JSC::jsString(this->vm(), makeString("v", REPORTED_NODE_VERSION)));
// this gives some way of identifying at runtime whether the SSR is happening in node or not.
// this should probably be renamed to what the name of the bundler is, instead of "notNodeJS"

4
test/bun.js/process.test.js
View File

@@ -87,3 +87,7 @@ it("process.env", () => {
delete process.env["LOL SMILE latin1 <abc>"];
expect(process.env["LOL SMILE latin1 <abc>"]).toBe(undefined);
});
it("process.version starts with v", () => {
expect(process.version.startsWith("v")).toBeTruthy();
});