mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove isEmpty() check - inject synthetic frames even if stack exists

Browse Source 
Still not working - stack trace unchanged. Need to investigate further
why synthetic sourceURL/line/column aren't being used.
This commit is contained in:
Claude Bot
2025-10-06 03:35:10 +00:00
parent b3e705a428
commit 5745fd986e
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/bun.js/bindings/ZigGlobalObject.cpp
View File

@@ -783,8 +783,9 @@ static String computeErrorInfoToString(JSC::VM& vm, Vector<StackFrame>& stackTra
Zig::GlobalObject* globalObject = nullptr;
JSC::JSGlobalObject* lexicalGlobalObject = nullptr;
// If this is a BuildMessage or ResolveMessage with an empty stack, inject synthetic location
if (bunErrorData != nullptr && stackTrace.isEmpty()) {
// If this is a BuildMessage or ResolveMessage, replace any existing stack with synthetic location
// The captured stack will be from bundler internals, not user code
if (bunErrorData != nullptr) {
void* buildMessage = Bun__getBuildMessage(bunErrorData);
void* resolveMessage = Bun__getResolveMessage(bunErrorData);
@@ -817,9 +818,9 @@ static JSValue computeErrorInfoToJSValueWithoutSkipping(JSC::VM& vm, Vector<Stac
globalObject = jsDynamicCast<Zig::GlobalObject*>(lexicalGlobalObject);
auto scope = DECLARE_THROW_SCOPE(vm);
// If this is a BuildMessage or ResolveMessage with an empty stack, inject a synthetic stack frame
// from the location data in the message
if (bunErrorData != nullptr && stackTrace.isEmpty()) {
// If this is a BuildMessage or ResolveMessage, replace any existing stack with synthetic location
// The captured stack will be from bundler internals, not user code
if (bunErrorData != nullptr) {
void* buildMessage = Bun__getBuildMessage(bunErrorData);
void* resolveMessage = Bun__getResolveMessage(bunErrorData);