mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-10 10:58:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(runtime): exclude globalThis from auto-serve detection (#26107)

Browse Source 
## Summary
- When a module exports `globalThis` (e.g., `module.exports =
globalThis`), Bun's auto-serve detection incorrectly triggered because
`globalThis.fetch` is the Fetch API function
- Scripts that export globalThis (like `core-js/es/global-this.js`)
would start a development server on port 3000 instead of exiting
normally
- Added explicit check to skip auto-serve when the default export is
`globalThis` itself

Fixes #440

## Test plan
- [x] Added test case `test/regression/issue/440.test.ts` that verifies:
  - `module.exports = globalThis` does not start a server
  - `export default globalThis` does not start a server
- [x] Verified test fails with system Bun (without fix)
- [x] Verified test passes with debug build (with fix)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Bot <claude-bot@bun.sh>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
robobun
2026-01-14 17:41:21 -08:00
committed by GitHub
parent 6104705f5f
commit 798b48c898
2 changed files with 50 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/bundler/entry_points.zig
View File

@@ -169,7 +169,7 @@ pub const ServerEntryPoint = struct {
\\if (typeof entryNamespace?.then === 'function') {{
\\ entryNamespace = entryNamespace.then((entryNamespace) => {{
\\ var def = entryNamespace?.default;
\\ if (def && (typeof def.fetch === 'function' || def.app != undefined)) {{
\\ if (def && def !== globalThis && (typeof def.fetch === 'function' || def.app != undefined)) {{
\\ var server = globalThis[hmrSymbol];
\\ if (server) {{
\\ server.reload(def);
@@ -180,7 +180,7 @@ pub const ServerEntryPoint = struct {
\\ }}
\\ }}
\\ }}, reportError);
\\}} else if (typeof entryNamespace?.default?.fetch === 'function' || entryNamespace?.default?.app != undefined) {{
\\}} else if (entryNamespace?.default !== globalThis && (typeof entryNamespace?.default?.fetch === 'function' || entryNamespace?.default?.app != undefined)) {{
\\ var server = globalThis[hmrSymbol];
\\ if (server) {{
\\ server.reload(entryNamespace.default);
@@ -204,12 +204,12 @@ pub const ServerEntryPoint = struct {
\\var entryNamespace = start;
\\if (typeof entryNamespace?.then === 'function') {{
\\ entryNamespace = entryNamespace.then((entryNamespace) => {{
\\ if (typeof entryNamespace?.default?.fetch === 'function') {{
\\ if (entryNamespace?.default !== globalThis && typeof entryNamespace?.default?.fetch === 'function') {{
\\ const server = Bun.serve(entryNamespace.default);
\\ console.debug(`Started ${{server.development ? 'development ' : ''}}server: ${{server.protocol}}://${{server.hostname}}:${{server.port}}`);
\\ }}
\\ }}, reportError);
\\}} else if (typeof entryNamespace?.default?.fetch === 'function' || entryNamespace?.default?.app != null) {{
\\}} else if (entryNamespace?.default !== globalThis && (typeof entryNamespace?.default?.fetch === 'function' || entryNamespace?.default?.app != null)) {{
\\ const server = Bun.serve(entryNamespace.default);
\\ console.debug(`Started ${{server.development ? 'development ' : ''}}server: ${{server.protocol}}://${{server.hostname}}:${{server.port}}`);
\\}}

46
test/regression/issue/440.test.ts Normal file
View File

@@ -0,0 +1,46 @@
import { expect, test } from "bun:test";
import { bunEnv, bunExe, tempDir } from "harness";
test("exporting globalThis should not start a server", async () => {
using dir = tempDir("issue-440", {
"test.js": `module.exports = globalThis;`,
});
await using proc = Bun.spawn({
cmd: [bunExe(), "test.js"],
env: bunEnv,
cwd: String(dir),
stdout: "pipe",
stderr: "pipe",
});
const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]);
// Should NOT contain server started message
expect(stderr).not.toContain("Started");
expect(stderr).not.toContain("server:");
expect(stdout).toBe("");
expect(exitCode).toBe(0);
});
test("default export of globalThis should not start a server", async () => {
using dir = tempDir("issue-440-esm", {
"test.js": `export default globalThis;`,
});
await using proc = Bun.spawn({
cmd: [bunExe(), "test.js"],
env: bunEnv,
cwd: String(dir),
stdout: "pipe",
stderr: "pipe",
});
const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]);
// Should NOT contain server started message
expect(stderr).not.toContain("Started");
expect(stderr).not.toContain("server:");
expect(stdout).toBe("");
expect(exitCode).toBe(0);
});