mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-10 19:08:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect public TS class field name minification (#15411)

Browse Source
This commit is contained in:
Kai Tamkun
2024-11-27 14:06:09 -08:00
committed by GitHub
parent 1bb211df56
commit 7fd16ebffa
3 changed files with 32 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/js_parser.zig
View File

@@ -21821,8 +21821,9 @@ fn NewParser_(
if (arg.is_typescript_ctor_field) {
switch (arg.binding.data) {
.b_identifier => |id| {
const name = p.symbols.items[id.ref.innerIndex()].original_name;
const ident = p.newExpr(E.Identifier{ .ref = id.ref }, arg.binding.loc);
const arg_symbol = p.symbols.items[id.ref.innerIndex()];
const name = arg_symbol.original_name;
const arg_ident = p.newExpr(E.Identifier{ .ref = id.ref }, arg.binding.loc);
stmts.insert(if (super_index) |k| j + k + 1 else j, Stmt.assign(
p.newExpr(E.Dot{
@@ -21830,12 +21831,17 @@ fn NewParser_(
.name = name,
.name_loc = arg.binding.loc,
}, arg.binding.loc),
ident,
arg_ident,
)) catch unreachable;
// O(N)
class_body.items.len += 1;
bun.copy(G.Property, class_body.items[j + 1 ..], class_body.items[j .. class_body.items.len - 1]);
class_body.items[j] = G.Property{ .key = ident };
// Copy the argument name symbol to prevent the class field declaration from being renamed
// but not the constructor argument.
const field_symbol_ref = p.declareSymbol(.other, arg.binding.loc, name) catch id.ref;
field_symbol_ref.getSymbol(p.symbols.items).must_not_be_renamed = true;
const field_ident = p.newExpr(E.Identifier{ .ref = field_symbol_ref }, arg.binding.loc);
class_body.items[j] = G.Property{ .key = field_ident };
j += 1;
},
else => {},

2
src/js_printer.zig
View File

@@ -576,7 +576,7 @@ pub const PrintResult = union(enum) {
// do not make this a packed struct
// stage1 compiler bug:
// > /optional-chain-with-function.js: Evaluation failed: TypeError: (intermediate value) is not a function
// this test failure was caused by the packed structi mplementation
// this test failure was caused by the packed struct implementation
const ExprFlag = enum {
forbid_call,
forbid_in,

21
test/bundler/bundler_edgecase.test.ts
View File

@@ -2253,4 +2253,25 @@ describe("bundler", () => {
stdout: "windows",
},
});
itBundled("edgecase/TSPublicFieldMinification", {
files: {
"/entry.ts": /* ts */ `
export class Foo {
constructor(public name: string) {}
}
const keys = Object.keys(new Foo('test'))
if (keys.length !== 1) throw new Error('Keys length is not 1')
if (keys[0] !== 'name') throw new Error('keys[0] is not "name"')
console.log('success')
`,
},
minifySyntax: true,
minifyIdentifiers: true,
target: "bun",
run: {
stdout: "success",
},
});
});