mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Assert there is an env when calling external finalizer

Browse Source
This commit is contained in:
Ben Grant
2024-11-11 16:31:58 -08:00
parent 657f5b9f6a
commit 8b5fb349dd
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/bun.js/bindings/napi_external.cpp
View File

@@ -6,6 +6,7 @@ namespace Bun {
NapiExternal::~NapiExternal()
{
if (m_finalizer) {
ASSERT(m_env);
m_finalizer->call(m_env, m_value);
}
}

4
src/bun.js/bindings/v8/V8External.cpp
View File

@@ -12,8 +12,8 @@ Local<External> External::New(Isolate* isolate, void* value)
auto globalObject = isolate->globalObject();
auto& vm = globalObject->vm();
auto structure = globalObject->NapiExternalStructure();
// TODO(@190n): ponder the second nullptr argument (napi_env).
Bun::NapiExternal* val = Bun::NapiExternal::create(vm, structure, value, nullptr, nullptr, nullptr);
Bun::NapiExternal* val = Bun::NapiExternal::create(vm, structure, value,
nullptr /* hint */, nullptr /* env */, nullptr /* callback */);
return isolate->currentHandleScope()->createLocal<External>(vm, val);
}