mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-16 13:51:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: make CHANGELOG files respect .npmignore settings

Browse Source 
CHANGELOG files should obey .npmignore directives like any other file. 
Previously, CHANGELOG files were being unconditionally included in packages, 
even when listed in .npmignore, which is inconsistent with npm's behavior.

This change removes the special treatment of CHANGELOG files so they can be 
properly ignored when listed in .npmignore.

Fixes #18691

Co-authored-by: Electroid <Electroid@users.noreply.github.com>

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>"
This commit is contained in:
claude[bot]
2025-05-19 19:18:33 +00:00
committed by GitHub
parent 457c15e424
commit 91c065d8c8
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/cli/pack_command.zig
View File

@@ -1066,7 +1066,7 @@ pub const PackCommand = struct {
if (dir_depth == 1) {
// first, check files that can never be ignored. project root
// directory only
if (isUnconditionallyIncludedFile(entry_name) or isSpecialFileOrVariant(entry_name, "CHANGELOG")) {
if (isUnconditionallyIncludedFile(entry_name)) {
return null;
}

5
test/cli/install/bun-pack.test.ts
View File

@@ -931,7 +931,7 @@ describe("files", () => {
]);
});
test(".npmignore cannot exclude CHANGELOG", async () => {
test(".npmignore can exclude CHANGELOG", async () => {
await Promise.all([
write(
join(packageDir, "package.json"),
@@ -949,9 +949,6 @@ describe("files", () => {
const tarball = readTarball(join(packageDir, "pack-files-changelog-1.1.2.tgz"));
expect(tarball.entries).toMatchObject([
{ "pathname": "package/package.json" },
{ "pathname": "package/CHANGELOG" },
{ "pathname": "package/CHANGELOG.md" },
{ "pathname": "package/CHANGELOG.txt" },
]);
});