mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect indexOfNotChar causing sourcemaps bugs

Browse Source
This commit is contained in:
Jarred Sumner
2022-08-25 18:52:58 -07:00
parent e6a1209c53
commit 950d03a9ea
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/string_immutable.zig
View File

@@ -2829,7 +2829,7 @@ pub fn indexOfNotChar(slice: []const u8, char: u8) ?u32 {
while (remaining.len >= ascii_vector_size) {
const vec: AsciiVector = remaining[0..ascii_vector_size].*;
const cmp = @splat(ascii_vector_size, char) != vec;
if (@reduce(.Min, @bitCast(AsciiVectorU1, cmp)) > 0) {
if (@reduce(.Max, @bitCast(AsciiVectorU1, cmp)) > 0) {
const bitmask = @ptrCast(*const AsciiVectorInt, &cmp).*;
const first = @ctz(AsciiVectorInt, bitmask);
return @as(u32, first) + @intCast(u32, slice.len - remaining.len);
@@ -3117,12 +3117,14 @@ pub fn @"nextUTF16NonASCIIOr$`\\"(
test "indexOfNotChar" {
{
const yes = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
try std.testing.expectEqual(indexOfNotChar(yes, 'a').?, 36);
}
{
const yes = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
try std.testing.expectEqual(indexOfNotChar(yes, 'a').?, 108);
var yes: [312]u8 = undefined;
var i: usize = 0;
while (i < yes.len) {
@memset(&yes, 'a', yes.len);
yes[i] = 'b';
assert(indexOfNotChar(&yes, 'a').? == i);
i += 1;
}
}
}