mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-12 03:48:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix date format (#2422) (#2474)

Browse Source 
* Fix date format (#2422)

* Add unit tests for #2422
This commit is contained in:
Adrien Zinger
2023-03-30 02:41:11 +02:00
committed by GitHub
parent b0e0853360
commit 95cb2b2ac2
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/bun.js/bindings/exports.zig
View File

@@ -2304,7 +2304,10 @@ pub const ZigConsoleClient = struct {
// in the code for printing dates, it never exceeds this amount
var iso_string_buf: [36]u8 = undefined;
var out_buf: []const u8 = std.fmt.bufPrint(&iso_string_buf, "{}", .{str}) catch "";
if (out_buf.len > 2) {
if (strings.eql(out_buf, "null")) {
out_buf = "Invalid Date";
} else if (out_buf.len > 2) {
// trim the quotes
out_buf = out_buf[1 .. out_buf.len - 1];
}

12
test/js/bun/util/inspect.test.js
View File

@@ -337,3 +337,15 @@ describe("crash testing", () => {
it("possibly formatted emojis log", () => {
expect(Bun.inspect("✔", "hey")).toBe("✔ hey");
});
it("new Date(..)", () => {
expect(Bun.inspect(new Date(1679911059000))).toBe("2023-03-27T09:54:00.000Z");
expect(Bun.inspect(new Date("March 27, 2023 09:54:00"))).toBe("2023-03-27T09:54:00.000Z");
expect(Bun.inspect(new Date("2023-03-27T09:54:00"))).toBe("2023-03-27T09:54:00.000Z");
expect(Bun.inspect(new Date(2023, 02, 27))).toBe("2023-03-27T00:00:00.000Z");
expect(Bun.inspect(new Date(2023, 02, 27, 09, 54, 0))).toBe("2023-03-27T09:54:00.000Z");
expect(Bun.inspect(new Date("1679911059000"))).toBe("Invalid Date");
expect(Bun.inspect(new Date("hello world"))).toBe("Invalid Date");
expect(Bun.inspect(new Date("Invalid Date"))).toBe("Invalid Date");
});