mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

node: fix test-net-connect-options-invalid.js (#17824)

Browse Source
This commit is contained in:
Meghan Denny
2025-03-03 21:57:13 -08:00
committed by GitHub
parent 2d0cadc949
commit 99d85be529
2 changed files with 34 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/js/node/net.ts
View File

@@ -517,6 +517,13 @@ const Socket = (function (InternalSocket) {
...opts
} = options || {};
if (options?.objectMode)
throw $ERR_INVALID_ARG_VALUE("options.objectMode", options.objectMode, "is not supported");
if (options?.readableObjectMode)
throw $ERR_INVALID_ARG_VALUE("options.readableObjectMode", options.readableObjectMode, "is not supported");
if (options?.writableObjectMode)
throw $ERR_INVALID_ARG_VALUE("options.writableObjectMode", options.writableObjectMode, "is not supported");
super({
...opts,
allowHalfOpen,

27
test/js/node/test/parallel/test-net-connect-options-invalid.js Normal file
View File

@@ -0,0 +1,27 @@
'use strict';
require('../common');
const assert = require('assert');
const net = require('net');
{
const invalidKeys = [
'objectMode',
'readableObjectMode',
'writableObjectMode',
];
invalidKeys.forEach((invalidKey) => {
const option = {
port: 8080,
[invalidKey]: true
};
const message = `The property 'options.${invalidKey}' is not supported. Received true`;
assert.throws(() => {
net.createConnection(option);
}, {
code: 'ERR_INVALID_ARG_VALUE',
name: 'TypeError',
message: new RegExp(message)
});
});
}