mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 18:38:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): replace timing-based waits with condition-based waits in SIGUSR1 tests

Browse Source 
Replace Bun.sleep() calls with condition-based waiting to avoid flaky tests.
Instead of waiting for an arbitrary amount of time, now we read from stderr
until the expected "Debugger listening" message appears.

Changes:
- First test: read stderr until "Debugger listening" appears before killing
- Third test: wait for "Debugger listening" before sending second SIGUSR1
- Fifth/sixth tests: remove unnecessary sleeps since signal processing is
  synchronous and we can kill immediately after sending SIGUSR1
This commit is contained in:
Alistair Smith
2026-01-05 16:37:09 +00:00
committed by Claude
parent c25572ebfe
commit a028ee95df
1 changed files with 34 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
test/js/bun/runtime-inspector/runtime-inspector-posix.test.ts
View File

@@ -44,12 +44,21 @@ describe.skipIf(isWindows)("Runtime inspector SIGUSR1 activation", () => {
// Send SIGUSR1
process.kill(pid, "SIGUSR1");
// Give inspector time to activate
await Bun.sleep(100);
// Wait for inspector to activate by reading stderr until "Debugger listening" appears
const stderrReader = proc.stderr.getReader();
const stderrDecoder = new TextDecoder();
let stderr = "";
// Kill process and check stderr
while (!stderr.includes("Debugger listening")) {
const { value, done } = await stderrReader.read();
if (done) break;
stderr += stderrDecoder.decode(value, { stream: true });
}
stderrReader.releaseLock();
// Kill process
proc.kill();
const [stderr] = await Promise.all([proc.stderr.text(), proc.exited]);
await proc.exited;
expect(stderr).toContain("Debugger listening on ws://127.0.0.1:6499/");
});
@@ -144,12 +153,27 @@ describe.skipIf(isWindows)("Runtime inspector SIGUSR1 activation", () => {
const pid = parseInt(await Bun.file(join(String(dir), "pid")).text(), 10);
// Send SIGUSR1 twice - inspector should only activate once
process.kill(pid, "SIGUSR1");
await Bun.sleep(50);
// Send first SIGUSR1 and wait for inspector to activate
process.kill(pid, "SIGUSR1");
const [stderr, exitCode] = await Promise.all([proc.stderr.text(), proc.exited]);
const stderrReader = proc.stderr.getReader();
const stderrDecoder = new TextDecoder();
let stderr = "";
// Wait until we see "Debugger listening" before sending second signal
while (!stderr.includes("Debugger listening")) {
const { value, done } = await stderrReader.read();
if (done) break;
stderr += stderrDecoder.decode(value, { stream: true });
}
// Send second SIGUSR1 - inspector should not activate again
process.kill(pid, "SIGUSR1");
// Read any remaining stderr until process exits
stderrReader.releaseLock();
const [remainingStderr, exitCode] = await Promise.all([proc.stderr.text(), proc.exited]);
stderr += remainingStderr;
// Should only see one "Debugger listening" message
const matches = stderr.match(/Debugger listening/g);
@@ -256,10 +280,8 @@ describe.skipIf(isWindows)("Runtime inspector SIGUSR1 activation", () => {
// Send SIGUSR1 - should be ignored since debugger is already active
process.kill(proc.pid, "SIGUSR1");
// Wait a bit for the signal to be processed
await Bun.sleep(100);
// Kill process since --inspect-wait would wait for connection
// Signal processing is synchronous, so no sleep needed
proc.kill();
// Read any remaining stderr
@@ -305,10 +327,8 @@ describe.skipIf(isWindows)("Runtime inspector SIGUSR1 activation", () => {
// Send SIGUSR1 - should be ignored since debugger is already active
process.kill(proc.pid, "SIGUSR1");
// Wait a bit for the signal to be processed
await Bun.sleep(100);
// Kill process since --inspect-brk would wait for connection
// Signal processing is synchronous, so no sleep needed
proc.kill();
// Read any remaining stderr