mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-12 20:09:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make node:vm 12x faster

Browse Source
This commit is contained in:
Jarred Sumner
2023-05-18 19:27:02 -07:00
parent f862ae4050
commit a3e53b025e
3 changed files with 39 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/bun.js/bindings/NodeVMScript.cpp
View File

@@ -107,12 +107,26 @@ static EncodedJSValue runInContext(JSGlobalObject* globalObject, NodeVMScript* s
}
auto err_scope = DECLARE_THROW_SCOPE(vm);
auto* eval = DirectEvalExecutable::create(
globalObject, script->source(), DerivedContextType::None, NeedsClassFieldInitializer::No, PrivateBrandRequirement::None,
false, false, EvalContextType::None, nullptr, nullptr, ECMAMode::sloppy());
RETURN_IF_EXCEPTION(err_scope, {});
JSC::DirectEvalExecutable* executable = nullptr;
return JSValue::encode(vm.interpreter.executeEval(eval, globalObject, scope));
if (JSC::JSGlobalObject* cachedGlobalObject = script->m_cachedGlobalObject.get()) {
if (cachedGlobalObject == globalObject) {
if (JSC::DirectEvalExecutable* existingEval = script->m_cachedDirectExecutable.get()) {
executable = existingEval;
}
}
}
if (executable == nullptr) {
executable = JSC::DirectEvalExecutable::create(
globalObject, script->source(), DerivedContextType::None, NeedsClassFieldInitializer::No, PrivateBrandRequirement::None,
false, false, EvalContextType::None, nullptr, nullptr, ECMAMode::sloppy());
RETURN_IF_EXCEPTION(err_scope, {});
script->m_cachedDirectExecutable.set(vm, script, executable);
script->m_cachedGlobalObject.set(vm, script, globalObject);
}
return JSValue::encode(vm.interpreter.executeEval(executable, globalObject, scope));
}
JSC_DEFINE_HOST_FUNCTION(scriptConstructorCall, (JSGlobalObject * globalObject, CallFrame* callFrame))
@@ -291,6 +305,18 @@ const ClassInfo NodeVMScriptPrototype::s_info = { "Script"_s, &Base::s_info, nul
const ClassInfo NodeVMScript::s_info = { "Script"_s, &Base::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(NodeVMScript) };
const ClassInfo NodeVMScriptConstructor::s_info = { "Script"_s, &Base::s_info, nullptr, nullptr, CREATE_METHOD_TABLE(NodeVMScriptConstructor) };
DEFINE_VISIT_CHILDREN(NodeVMScript);
template<typename Visitor>
void NodeVMScript::visitChildrenImpl(JSCell* cell, Visitor& visitor)
{
NodeVMScript* thisObject = jsCast<NodeVMScript*>(cell);
ASSERT_GC_OBJECT_INHERITS(thisObject, info());
Base::visitChildren(thisObject, visitor);
visitor.append(thisObject->m_cachedDirectExecutable);
visitor.append(thisObject->m_cachedGlobalObject);
}
NodeVMScriptConstructor::NodeVMScriptConstructor(VM& vm, Structure* structure)
: NodeVMScriptConstructor::Base(vm, structure, scriptConstructorCall, scriptConstructorConstruct)
{
@@ -339,5 +365,4 @@ void NodeVMScript::destroy(JSCell* cell)
{
static_cast<NodeVMScript*>(cell)->NodeVMScript::~NodeVMScript();
}
}

4
src/bun.js/bindings/NodeVMScript.h
View File

@@ -61,6 +61,10 @@ public:
const JSC::SourceCode& source() const { return m_source; }
DECLARE_VISIT_CHILDREN;
mutable WriteBarrier<JSC::DirectEvalExecutable> m_cachedDirectExecutable;
mutable WriteBarrier<JSC::JSGlobalObject> m_cachedGlobalObject;
private:
JSC::SourceCode m_source;

8
src/bun.js/vm.exports.js
View File

@@ -27,17 +27,17 @@ Script.prototype.runInNewContext = function (contextObject, options) {
contextObject = {};
}
const context = createContext(contextObject);
this.runInContext(context, options);
return this.runInContext(context, options);
};
function runInContext(code, context, options) {
new Script(code).runInContext(context, options);
return new Script(code).runInContext(context, options);
}
function runInNewContext(code, contextObject, options) {
new Script(code).runInNewContext(contextObject, options);
return new Script(code).runInNewContext(contextObject, options);
}
function runInThisContext(code, options) {
new Script(code).runInNewContext(options);
return new Script(code).runInNewContext(options);
}
function compileFunction() {
notimpl("compileFunction");