mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-02 15:08:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

ci: increase asan to 2xlarge (#22916)

Browse Source
This commit is contained in:
Meghan Denny
2025-09-23 13:16:01 -08:00
committed by GitHub
parent e555702653
commit b82c676ce5
3 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
.buildkite/ci.mjs
View File

@@ -371,7 +371,7 @@ function getZigAgent(platform, options) {
* @returns {Agent}
*/
function getTestAgent(platform, options) {
const { os, arch } = platform;
const { os, arch, profile } = platform;
if (os === "darwin") {
return {
@@ -391,6 +391,13 @@ function getTestAgent(platform, options) {
}
if (arch === "aarch64") {
if (profile === "asan") {
return getEc2Agent(platform, options, {
instanceType: "c8g.2xlarge",
cpuCount: 2,
threadsPerCore: 1,
});
}
return getEc2Agent(platform, options, {
instanceType: "c8g.xlarge",
cpuCount: 2,
@@ -398,6 +405,13 @@ function getTestAgent(platform, options) {
});
}
if (profile === "asan") {
return getEc2Agent(platform, options, {
instanceType: "c7i.2xlarge",
cpuCount: 2,
threadsPerCore: 1,
});
}
return getEc2Agent(platform, options, {
instanceType: "c7i.xlarge",
cpuCount: 2,

4
scripts/runner.node.mjs
View File

@@ -72,6 +72,7 @@ const cwd = import.meta.dirname ? dirname(import.meta.dirname) : process.cwd();
const testsPath = join(cwd, "test");
const spawnTimeout = 5_000;
const spawnBunTimeout = 20_000; // when running with ASAN/LSAN bun can take a bit longer to exit, not a bug.
const testTimeout = 3 * 60_000;
const integrationTimeout = 5 * 60_000;
@@ -1152,6 +1153,9 @@ async function spawnBun(execPath, { args, cwd, timeout, env, stdout, stderr }) {
}
bunEnv["TEMP"] = tmpdirPath;
}
if (timeout === undefined) {
timeout = spawnBunTimeout;
}
try {
const existingCores = options["coredump-upload"] ? readdirSync(coresDir) : [];
const result = await spawnSafe({

10
src/bun.js/bindings/bindings.cpp
View File

@@ -4102,10 +4102,12 @@ extern "C" JSC::EncodedJSValue JSC__JSValue__getOwn(JSC::EncodedJSValue JSValue0
auto identifier = JSC::Identifier::fromString(vm, propertyNameString);
auto property = JSC::PropertyName(identifier);
PropertySlot slot(value, PropertySlot::InternalMethodType::GetOwnProperty);
if (value.getOwnPropertySlot(globalObject, property, slot)) {
RELEASE_AND_RETURN(scope, JSValue::encode(slot.getValue(globalObject, property)));
}
RELEASE_AND_RETURN(scope, {});
bool hasSlot = value.getOwnPropertySlot(globalObject, property, slot);
RETURN_IF_EXCEPTION(scope, {});
if (!hasSlot) return {};
auto slotValue = slot.getValue(globalObject, property);
RETURN_IF_EXCEPTION(scope, {});
return JSValue::encode(slotValue);
}
JSC::EncodedJSValue JSC__JSValue__getIfPropertyExistsFromPath(JSC::EncodedJSValue JSValue0, JSC::JSGlobalObject* globalObject, JSC::EncodedJSValue arg1)