mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-09 10:28:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove dead ucs2 case labels after normalization

Browse Source 
Since ucs2 is normalized to utf16le at the start of jsBufferFunction_transcode,
all `case BufferEncodingType::ucs2:` labels in the switch statements are
unreachable dead code. Removed them and added clarifying comments.

No functional changes - all tests still pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Claude Bot
2025-10-31 02:15:35 +00:00
parent d43b3e3119
commit bd9fbc0cd3
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/bun.js/bindings/JSBuffer.cpp
View File

@@ -2145,9 +2145,8 @@ static JSC::JSUint8Array* transcodeBuffer(
switch (fromEncoding) {
case BufferEncodingType::utf8: {
switch (toEncoding) {
case BufferEncodingType::utf16le:
case BufferEncodingType::ucs2: {
// UTF-8 to UTF-16LE
case BufferEncodingType::utf16le: {
// UTF-8 to UTF-16LE (ucs2 normalized to utf16le earlier)
size_t expectedLength = simdutf::utf16_length_from_utf8(reinterpret_cast<const char*>(source), sourceLength);
result = createUninitializedBuffer(lexicalGlobalObject, expectedLength * 2);
RETURN_IF_EXCEPTION(scope, nullptr);
@@ -2198,9 +2197,8 @@ static JSC::JSUint8Array* transcodeBuffer(
}
break;
}
case BufferEncodingType::utf16le:
case BufferEncodingType::ucs2: {
// Source is UTF-16LE
case BufferEncodingType::utf16le: {
// Source is UTF-16LE (ucs2 normalized to utf16le earlier)
size_t utf16Length = sourceLength / 2;
const char16_t* utf16Source = reinterpret_cast<const char16_t*>(source);
@@ -2280,9 +2278,8 @@ static JSC::JSUint8Array* transcodeBuffer(
return result;
}
case BufferEncodingType::utf16le:
case BufferEncodingType::ucs2: {
// Latin1 to UTF-16LE
case BufferEncodingType::utf16le: {
// Latin1 to UTF-16LE (ucs2 normalized to utf16le earlier)
result = createUninitializedBuffer(lexicalGlobalObject, sourceLength * 2);
RETURN_IF_EXCEPTION(scope, nullptr);