mirrors/bun.sh
1
0
Fork 0
mirror of https://github.com/oven-sh/bun synced 2026-02-12 03:48:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in WebSocket

Browse Source
This commit is contained in:
Jarred Sumner
2022-08-18 23:41:33 -07:00
parent 0f45386673
commit bdf733973c
1 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/bun.js/bindings/webcore/WebSocket.cpp
View File

@@ -831,18 +831,9 @@ void WebSocket::didReceiveMessageError(WTF::StringImpl::StaticStringImpl* reason
m_state = CLOSED;
if (auto* context = scriptExecutionContext()) {
this->m_pendingActivityCount++;
context->postTask([this, reason, protectedThis = Ref { *this }](ScriptExecutionContext& context) {
ASSERT(scriptExecutionContext());
// if (UNLIKELY(InspectorInstrumentation::hasFrontends())) {
// if (auto* inspector = m_channel->channelInspector())
// inspector->didReceiveWebSocketFrameError(reason);
// }
// FIXME: As per https://html.spec.whatwg.org/multipage/web-sockets.html#feedback-from-the-protocol:concept-websocket-closed, we should synchronously fire a close event.
dispatchEvent(CloseEvent::create(false, 0, WTF::String(reason)));
protectedThis->m_pendingActivityCount--;
});
// https://html.spec.whatwg.org/multipage/web-sockets.html#feedback-from-the-protocol:concept-websocket-closed, we should synchronously fire a close event.
dispatchEvent(CloseEvent::create(false, 0, WTF::String(reason)));
this->m_pendingActivityCount--;
}
}
@@ -894,7 +885,7 @@ void WebSocket::didClose(unsigned unhandledBufferedAmount, unsigned short code,
context->postTask([this, code, wasClean, reason, protectedThis = Ref { *this }](ScriptExecutionContext& context) {
ASSERT(scriptExecutionContext());
protectedThis->dispatchEvent(CloseEvent::create(wasClean, code, reason));
protectedThis->m_pendingActivityCount++;
protectedThis->m_pendingActivityCount--;
});
}